Fixing the issue where byNumber[slideNumber] was undefined, yet we we…

…re still calling .push on it
Taku-Yamashita · Jan 27, 2020 · b3b05ff · b3b05ff
1 parent 637be99
commit b3b05ff
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/remark/models/slideshow.js b/src/remark/models/slideshow.js
@@ -234,7 +234,9 @@ function createSlides (slideshowSource, options) {
     } else {
       if (slideIsIncluded) {
         slides.push(slideViewModel);
-        slides.byNumber[slideNumber].push(slideViewModel);
+        if (slides.byNumber[slideNumber] !== undefined) {
+          slides.byNumber[slideNumber].push(slideViewModel);
+        }
       }
       if (slide.properties.name) {
         slides.byName[slide.properties.name] = slideViewModel;

diff --git a/test/remark/models/slideshow_test.js b/test/remark/models/slideshow_test.js
@@ -105,6 +105,14 @@ describe('Slideshow', function () {
     });
   });
 
+  describe('non-countable slides', function() {
+    it('should not be counted if set on first slide', function() {
+      slideshow.loadFromString('count: false\n\na\n---\nb');
+      slideshow.getSlides().length.should.equal(2);
+      slideshow.getSlidesByNumber(1)[0].getSlideNumber().should.equal(1);
+    });
+  });
+
   describe('name mapping', function () {
     it('should map named slide', function () {
       slideshow.loadFromString('name: a\n---\nno name\n---\nname: b');