优化代码。

TanJiaJunBeyond · Jul 26, 2021 · 4825107 · 4825107
1 parent af19e22
commit 4825107
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...n/java/com/tanjiajun/androidgenericframework/ui/repository/fragment/RepositoryFragment.kt b/...n/java/com/tanjiajun/androidgenericframework/ui/repository/fragment/RepositoryFragment.kt
@@ -56,7 +56,7 @@ class RepositoryFragment private constructor()
                         handlers = this@RepositoryFragment
                     }
                 }
-                this@RepositoryFragment.viewModel.isShowErrorView.observe(this@RepositoryFragment, Observer { isShowErrorView ->
+                this@RepositoryFragment.viewModel.isShowErrorView.observe(viewLifecycleOwner, Observer { isShowErrorView ->
                     if (isShowErrorView) {
                         if (!vsError.isInflated) {
                             vsError.viewStub?.inflate()?.also { errorView = it }
@@ -72,7 +72,7 @@ class RepositoryFragment private constructor()
     private fun initData() =
             with(viewModel) {
                 getRepositories(language)
-                repositories.observe(this@RepositoryFragment, Observer {
+                repositories.observe(viewLifecycleOwner, Observer {
                     adapter.setItems(it)
                 })
             }

diff --git a/app/src/main/java/com/tanjiajun/androidgenericframework/utils/BooleanExt.kt b/app/src/main/java/com/tanjiajun/androidgenericframework/utils/BooleanExt.kt
@@ -5,7 +5,7 @@ package com.tanjiajun.androidgenericframework.utils
  */
 sealed class BooleanExt<out T>
 
-class TransferData<T>(val data: T) : BooleanExt<T>()
+class TransferData<out T>(val data: T) : BooleanExt<T>()
 object Otherwise : BooleanExt<Nothing>()
 
 inline fun <T> Boolean.yes(block: () -> T): BooleanExt<T> =