Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bump the default ivy bootstrap jar to 2.4.0.
This has been the stable release for almost a year and pantsbuild/pants itself needs this version to properly handle the ANDROID_HOME env var detection it uses in ivysetting.xml. Previously, the bootstrap was 2.3.0 and the final used by pantsbuild/pants was 2.4.0 + extras. For any workspace with a cached final, the ivysettings.xml would work, but for workspaces w/o an ivy bootstrapped, the ivysettings.xml would fail. This change gets pantsbuild/pants ivysettings.xml working no matter the bootstrap phase. Testing Done: First noted the fact that the linux CI was green: https://travis-ci.org/pantsbuild/pants/builds/84007338 But the OSX CI was very red: https://travis-ci.org/pantsbuild-osx/pants/jobs/84014487 The 2 biggest differences being linux vs OS X and travis-ci cache vs none respectively. On my local machine, before the fix, I was able to reproduce the OS X CI failure mode by deleting my ivy bootstrap cache: `rm -rf ~/.cache/pants/tools/jvm/ivy/` After the fix I was no longer able to reproduce, all ran smooth through bootstrapping. CI went green here: https://travis-ci.org/pantsbuild/pants/builds/84017782 Bugs closed: 2333 Reviewed at https://rbcommons.com/s/twitter/r/2938/
- Loading branch information