Merge pull request coinbase#213 from blair/improve-gdax-cancel-all-or…

…ders-types cancelAllOrders: makde product argument optional.
TaoTeChing · Apr 10, 2018 · db30cb0 · db30cb0
2 parents 713bfd5 + 207dff2
commit db30cb0
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/src/core/Trader.ts b/src/core/Trader.ts
@@ -139,7 +139,7 @@ export class Trader extends Writable {
      * listed in the in-memory orderbook, use `cancelMyOrders`
      */
     cancelAllOrders(): Promise<string[]> {
-        return this.api.cancelAllOrders(null).then((ids: string[]) => {
+        return this.api.cancelAllOrders().then((ids: string[]) => {
             this.myBook.clear();
             this.emitMessageAsync('Trader.all-orders-cancelled', ids);
             return ids;

diff --git a/src/exchanges/AuthenticatedExchangeAPI.ts b/src/exchanges/AuthenticatedExchangeAPI.ts
@@ -36,9 +36,9 @@ export interface AuthenticatedExchangeAPI {
     cancelOrder(id: string): Promise<string>;
 
     /**
-     * Cancel all orders. If product is not null, only cancel orders from that book
+     * Cancel all orders. If product is truthy, only cancel orders from that book
      */
-    cancelAllOrders(product: string): Promise<string[]>;
+    cancelAllOrders(gdaxProduct?: string): Promise<string[]>;
 
     /**
      * Load details for a user-placed order on the exchange

diff --git a/src/exchanges/bitfinex/BitfinexExchangeAPI.ts b/src/exchanges/bitfinex/BitfinexExchangeAPI.ts
@@ -223,7 +223,7 @@ export class BitfinexExchangeAPI implements PublicExchangeAPI, AuthenticatedExch
         });
     }
 
-    cancelAllOrders(): Promise<string[]> {
+    cancelAllOrders(gdaxProduct?: string): Promise<string[]> {
         return this.checkAuth().then((auth: ExchangeAuthConfig) => {
             return BitfinexAuth.cancelAllOrders(auth).then((result: BitfinexResult) => {
                 if (this.logger) {

diff --git a/src/exchanges/ccxt/index.ts b/src/exchanges/ccxt/index.ts
@@ -297,7 +297,7 @@ export default class CCXTExchangeWrapper implements PublicExchangeAPI, Authentic
         throw new Error('Not implemented yet');
     }
 
-    cancelAllOrders(product: string): Promise<string[]> {
+    cancelAllOrders(gdaxProduct?: string): Promise<string[]> {
         throw new Error('Not implemented yet');
     }
 

diff --git a/src/exchanges/gdax/GDAXExchangeAPI.ts b/src/exchanges/gdax/GDAXExchangeAPI.ts
@@ -264,7 +264,7 @@ export class GDAXExchangeAPI implements PublicExchangeAPI, AuthenticatedExchange
 
     }
 
-    cancelAllOrders(product: string): Promise<string[]> {
+    cancelAllOrders(product?: string): Promise<string[]> {
         const apiCall = this.authCall('DELETE', `/orders`, {});
         const options = product ? {product_id: product} : null;
         return this.handleResponse<string[]>(apiCall, options);