Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uk_ua translation #22

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Add uk_ua translation #22

merged 3 commits into from
Sep 5, 2024

Conversation

masik16u
Copy link
Contributor

@masik16u masik16u commented Aug 23, 2024

A few things that were not easy to translate so they could be not totally correct:

  • "Mulberry": in Ukrainian it sounds similar to silk ("Mulberry Planks" would sound like "Silk Planks") so I chose one of the folk names of this tree.
  • On line 134 there is "item.verdance.mulberry": "Mulberry" I am not sure what that means so I put the tree name there
  • "Grilled": there is no appropriate word for this adjective so I used "Baked" instead
  • "Pitch": there is no appropriate word to say as one word so I used "Octave" instead

Everything else should be fine
P.S. The order of translation keys is very uncomfortable to work with, if you want I can help to organize it

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@ExDrill
Copy link
Contributor

ExDrill commented Aug 29, 2024

I'm going to hold on merging this, we're in the middle of working on the next update for Verdance

@ExDrill
Copy link
Contributor

ExDrill commented Aug 30, 2024

I'm going to hold on merging this, we're in the middle of working on the next update for Verdance

Regarding this, would you be willing to complete this PR to match the English language files once the update is complete? If so, I'll send another reply that the update's language files are ready to be translated.

@masik16u
Copy link
Contributor Author

I'm going to hold on merging this, we're in the middle of working on the next update for Verdance

Regarding this, would you be willing to complete this PR to match the English language files once the update is complete? If so, I'll send another reply that the update's language files are ready to be translated.

Sure, I will wait until you update the mod and then I will update the file

@ExDrill
Copy link
Contributor

ExDrill commented Sep 5, 2024

We've finished all content that require translations! Thanks in advance!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@masik16u
Copy link
Contributor Author

masik16u commented Sep 5, 2024

We've finished all content that require translations! Thanks in advance!

I think that's all

@ExDrill
Copy link
Contributor

ExDrill commented Sep 5, 2024

Thanks!

@ExDrill ExDrill closed this Sep 5, 2024
@ExDrill ExDrill reopened this Sep 5, 2024
@ExDrill ExDrill merged commit 3194914 into Team-Abode:1.21.x Sep 5, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants