Skip to content
This repository has been archived by the owner on Dec 14, 2022. It is now read-only.

Commit

Permalink
Merge tag 'staging-3.12-rc3' of git://git.kernel.org/pub/scm/linux/ke…
Browse files Browse the repository at this point in the history
…rnel/git/gregkh/staging

Pull staging fixes from Greg KH:
 "Here are some staging driver fixes, MAINTAINER updates, and a new
  device id.  All of these have been in the linux-next tree, and are
  pretty simple patches"

* tag 'staging-3.12-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging:
  staging: r8188eu: Add new device ID
  staging: imx-drm: Fix probe failure
  staging: vt6656: [BUG] iwctl_siwencodeext return if device not open
  staging: vt6656: [BUG] main_usb.c oops on device_close move flag earlier.
  staging: vt6656: rxtx.c [BUG] s_vGetFreeContext dead lock on null apTD.
  Staging: rtl8192u: r819xU_cmdpkt: checking NULL value after doing dev_alloc_skb
  staging: usbip: Orphan usbip
  staging: r8188eu: Add files for new drive: Cocci spatch "noderef"
  staging: r8188eu: Cocci spatch "noderef"
  staging: octeon-usb: Cocci spatch "noderef"
  staging: r8188eu: Add files for new drive: Cocci spatch "noderef"
  MAINTAINERS: staging: dgnc and dgap drivers: add maintainer
  staging: lustre: Cocci spatch "noderef"
  • Loading branch information
torvalds committed Sep 29, 2013
2 parents 434ac47 + df3f4ed commit 31795c4
Show file tree
Hide file tree
Showing 12 changed files with 31 additions and 16 deletions.
15 changes: 13 additions & 2 deletions MAINTAINERS
Original file line number Diff line number Diff line change
Expand Up @@ -2640,6 +2640,18 @@ F: include/linux/device-mapper.h
F: include/linux/dm-*.h
F: include/uapi/linux/dm-*.h

DIGI NEO AND CLASSIC PCI PRODUCTS
M: Lidza Louina <[email protected]>
L: [email protected]
S: Maintained
F: drivers/staging/dgnc/

DIGI EPCA PCI PRODUCTS
M: Lidza Louina <[email protected]>
L: [email protected]
S: Maintained
F: drivers/staging/dgap/

DIOLAN U2C-12 I2C DRIVER
M: Guenter Roeck <[email protected]>
L: [email protected]
Expand Down Expand Up @@ -8725,9 +8737,8 @@ F: Documentation/hid/hiddev.txt
F: drivers/hid/usbhid/

USB/IP DRIVERS
M: Matt Mooney <[email protected]>
L: [email protected]
S: Maintained
S: Orphan
F: drivers/staging/usbip/

USB ISP116X DRIVER
Expand Down
11 changes: 3 additions & 8 deletions drivers/staging/imx-drm/imx-drm-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ struct imx_drm_device {
struct list_head encoder_list;
struct list_head connector_list;
struct mutex mutex;
int references;
int pipes;
struct drm_fbdev_cma *fbhelper;
};
Expand Down Expand Up @@ -241,8 +240,6 @@ struct drm_device *imx_drm_device_get(void)
}
}

imxdrm->references++;

return imxdrm->drm;

unwind_crtc:
Expand Down Expand Up @@ -280,8 +277,6 @@ void imx_drm_device_put(void)
list_for_each_entry(enc, &imxdrm->encoder_list, list)
module_put(enc->owner);

imxdrm->references--;

mutex_unlock(&imxdrm->mutex);
}
EXPORT_SYMBOL_GPL(imx_drm_device_put);
Expand Down Expand Up @@ -485,7 +480,7 @@ int imx_drm_add_crtc(struct drm_crtc *crtc,

mutex_lock(&imxdrm->mutex);

if (imxdrm->references) {
if (imxdrm->drm->open_count) {
ret = -EBUSY;
goto err_busy;
}
Expand Down Expand Up @@ -564,7 +559,7 @@ int imx_drm_add_encoder(struct drm_encoder *encoder,

mutex_lock(&imxdrm->mutex);

if (imxdrm->references) {
if (imxdrm->drm->open_count) {
ret = -EBUSY;
goto err_busy;
}
Expand Down Expand Up @@ -709,7 +704,7 @@ int imx_drm_add_connector(struct drm_connector *connector,

mutex_lock(&imxdrm->mutex);

if (imxdrm->references) {
if (imxdrm->drm->open_count) {
ret = -EBUSY;
goto err_busy;
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/lustre/lustre/obdecho/echo_client.c
Original file line number Diff line number Diff line change
Expand Up @@ -1387,7 +1387,7 @@ echo_copyout_lsm (struct lov_stripe_md *lsm, void *_ulsm, int ulsm_nob)
if (nob > ulsm_nob)
return (-EINVAL);

if (copy_to_user (ulsm, lsm, sizeof(ulsm)))
if (copy_to_user (ulsm, lsm, sizeof(*ulsm)))
return (-EFAULT);

for (i = 0; i < lsm->lsm_stripe_count; i++) {
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/octeon-usb/cvmx-usb.c
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@ int cvmx_usb_initialize(struct cvmx_usb_state *state, int usb_port_number,
}
}

memset(usb, 0, sizeof(usb));
memset(usb, 0, sizeof(*usb));
usb->init_flags = flags;

/* Initialize the USB state structure */
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/rtl8188eu/core/rtw_mp.c
Original file line number Diff line number Diff line change
Expand Up @@ -907,7 +907,7 @@ u32 mp_query_psd(struct adapter *pAdapter, u8 *data)
sscanf(data, "pts =%d, start =%d, stop =%d", &psd_pts, &psd_start, &psd_stop);
}

_rtw_memset(data, '\0', sizeof(data));
_rtw_memset(data, '\0', sizeof(*data));

i = psd_start;
while (i < psd_stop) {
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ static void Init_ODM_ComInfo_88E(struct adapter *Adapter)
u8 cut_ver, fab_ver;

/* Init Value */
_rtw_memset(dm_odm, 0, sizeof(dm_odm));
_rtw_memset(dm_odm, 0, sizeof(*dm_odm));

dm_odm->Adapter = Adapter;

Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
Original file line number Diff line number Diff line change
Expand Up @@ -6973,7 +6973,7 @@ static int rtw_mp_ctx(struct net_device *dev,
stop = strncmp(extra, "stop", 4);
sscanf(extra, "count =%d, pkt", &count);

_rtw_memset(extra, '\0', sizeof(extra));
_rtw_memset(extra, '\0', sizeof(*extra));

if (stop == 0) {
bStartTest = 0; /* To set Stop */
Expand Down
1 change: 1 addition & 0 deletions drivers/staging/rtl8188eu/os_dep/usb_intf.c
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ static struct usb_device_id rtw_usb_id_tbl[] = {
/*=== Customer ID ===*/
/****** 8188EUS ********/
{USB_DEVICE(0x8179, 0x07B8)}, /* Abocom - Abocom */
{USB_DEVICE(0x2001, 0x330F)}, /* DLink DWA-125 REV D1 */
{} /* Terminating entry */
};

Expand Down
2 changes: 2 additions & 0 deletions drivers/staging/rtl8192u/r819xU_cmdpkt.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ rt_status SendTxCommandPacket(struct net_device *dev, void *pData, u32 DataLen)
/* Get TCB and local buffer from common pool.
(It is shared by CmdQ, MgntQ, and USB coalesce DataQ) */
skb = dev_alloc_skb(USB_HWDESC_HEADER_LEN + DataLen + 4);
if (!skb)
return RT_STATUS_FAILURE;
memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
tcb_desc = (cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
tcb_desc->queue_index = TXCMD_QUEUE;
Expand Down
3 changes: 3 additions & 0 deletions drivers/staging/vt6656/iwctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -1634,6 +1634,9 @@ int iwctl_siwencodeext(struct net_device *dev, struct iw_request_info *info,
if (pMgmt == NULL)
return -EFAULT;

if (!(pDevice->flags & DEVICE_FLAGS_OPENED))
return -ENODEV;

buf = kzalloc(sizeof(struct viawget_wpa_param), GFP_KERNEL);
if (buf == NULL)
return -ENOMEM;
Expand Down
3 changes: 2 additions & 1 deletion drivers/staging/vt6656/main_usb.c
Original file line number Diff line number Diff line change
Expand Up @@ -1098,6 +1098,8 @@ static int device_close(struct net_device *dev)
memset(pMgmt->abyCurrBSSID, 0, 6);
pMgmt->eCurrState = WMAC_STATE_IDLE;

pDevice->flags &= ~DEVICE_FLAGS_OPENED;

device_free_tx_bufs(pDevice);
device_free_rx_bufs(pDevice);
device_free_int_bufs(pDevice);
Expand All @@ -1109,7 +1111,6 @@ static int device_close(struct net_device *dev)
usb_free_urb(pDevice->pInterruptURB);

BSSvClearNodeDBTable(pDevice, 0);
pDevice->flags &=(~DEVICE_FLAGS_OPENED);

DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "device_close2 \n");

Expand Down
2 changes: 2 additions & 0 deletions drivers/staging/vt6656/rxtx.c
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,8 @@ static void *s_vGetFreeContext(struct vnt_private *pDevice)
DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO"GetFreeContext()\n");

for (ii = 0; ii < pDevice->cbTD; ii++) {
if (!pDevice->apTD[ii])
return NULL;
pContext = pDevice->apTD[ii];
if (pContext->bBoolInUse == false) {
pContext->bBoolInUse = true;
Expand Down

0 comments on commit 31795c4

Please sign in to comment.