Skip to content
This repository has been archived by the owner on Dec 14, 2022. It is now read-only.

Commit

Permalink
tracing/uprobe: Drop isdigit() check in create_trace_uprobe
Browse files Browse the repository at this point in the history
It's useless. Before:
  [tracing]# echo 'p:test /a:0x0' >> uprobe_events
  [tracing]# echo 'p:test a:0x0' >> uprobe_events
  -bash: echo: write error: No such file or directory
  [tracing]# echo 'p:test 1:0x0' >> uprobe_events
  -bash: echo: write error: Invalid argument

After:
  [tracing]# echo 'p:test 1:0x0' >> uprobe_events
  -bash: echo: write error: No such file or directory

Link: http://lkml.kernel.org/r/[email protected]

Acked-by: Srikar Dronamraju <[email protected]>
Acked-by: Oleg Nesterov <[email protected]>
Signed-off-by: Dmitry Safonov <[email protected]>
Signed-off-by: Steven Rostedt <[email protected]>
  • Loading branch information
0x7f454c46 authored and rostedt committed Sep 1, 2016
1 parent 3eab887 commit 5ba8a4a
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions kernel/trace/trace_uprobe.c
Original file line number Diff line number Diff line change
Expand Up @@ -427,10 +427,6 @@ static int create_trace_uprobe(int argc, char **argv)
pr_info("Probe point is not specified.\n");
return -EINVAL;
}
if (isdigit(argv[1][0])) {
pr_info("probe point must be have a filename.\n");
return -EINVAL;
}
arg = strchr(argv[1], ':');
if (!arg) {
ret = -EINVAL;
Expand Down

0 comments on commit 5ba8a4a

Please sign in to comment.