Override required dataSource for PersistentVolumeClaimSpec

Remove required attribute from openAPI and remove empty dataSource
fields in marshaller

See kubevirt#1882 (comment) for
more details.

pkg/util/openapi/openapi.go

@@ -94,6 +94,15 @@ func LoadOpenAPISpec(webServices []*restful.WebService) *spec.Swagger {
 			prop.Type = spec.StringOrArray{"string", "number"}
 			s.Properties["port"] = prop
 		}
+		if k == "v1.PersistentVolumeClaimSpec" {
+			for i, r := range s.Required {
+				if r == "dataSource" {
+					s.Required = append(s.Required[:i], s.Required[i+1:]...)
+					openapispec.Definitions[k] = s
+					break
+				}
+			}
+		}
 	}
 
 	return openapispec

tools/util/marshaller.go

@@ -45,6 +45,33 @@ func MarshallObject(obj interface{}, writer io.Writer) error {
 	unstructured.RemoveNestedField(r.Object, "spec", "template", "metadata", "creationTimestamp")
 	unstructured.RemoveNestedField(r.Object, "status")
 
+	// remove dataSource from PVCs if empty
+	templates, exists, err := unstructured.NestedSlice(r.Object, "spec", "dataVolumeTemplates")
+	if exists {
+		for _, tmpl := range templates {
+			template := tmpl.(map[string]interface{})
+			_, exists, err = unstructured.NestedString(template, "spec", "pvc", "dataSource")
+			if !exists {
+				unstructured.RemoveNestedField(template, "spec", "pvc", "dataSource")
+			}
+		}
+		unstructured.SetNestedSlice(r.Object, templates, "spec", "dataVolumeTemplates")
+	}
+	objects, exists, err := unstructured.NestedSlice(r.Object, "objects")
+	if exists {
+		for _, obj := range objects {
+			object := obj.(map[string]interface{})
+			kind, exists, _ := unstructured.NestedString(object, "kind")
+			if exists && kind == "PersistentVolumeClaim" {
+				_, exists, err = unstructured.NestedString(object, "spec", "dataSource")
+				if !exists {
+					unstructured.RemoveNestedField(object, "spec", "dataSource")
+				}
+			}
+		}
+		unstructured.SetNestedSlice(r.Object, objects, "objects")
+	}
+
 	// remove "managed by operator" label...
 	labels, exists, err := unstructured.NestedMap(r.Object, "metadata", "labels")
 	if exists {