Skip to content

Commit

Permalink
Bug 1719855 - Remove HasReceivedRealConfirmedTarget and eTimedOutAndM…
Browse files Browse the repository at this point in the history
…ainThreadResponded. r=botond

There was the only one call site of the function which was removed in bug
1804597.

Differential Revision: https://phabricator.services.mozilla.com/D176474
  • Loading branch information
hiikezoe committed Jun 22, 2023
1 parent 69c1519 commit 1148d52
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 15 deletions.
13 changes: 0 additions & 13 deletions gfx/layers/apz/src/InputBlockState.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,6 @@ bool InputBlockState::SetConfirmedTargetApzc(
MOZ_ASSERT(aState == TargetConfirmationState::eConfirmed ||
aState == TargetConfirmationState::eTimedOut);

if (mTargetConfirmed == TargetConfirmationState::eTimedOut &&
aState == TargetConfirmationState::eConfirmed) {
// The main thread finally responded. We had already timed out the
// confirmation, but we want to update the state internally so that we
// can record the time for telemetry purposes.
mTargetConfirmed = TargetConfirmationState::eTimedOutAndMainThreadResponded;
}
// Sometimes, bugs in compositor hit testing can lead to APZ confirming
// a different target than the main thread. If this happens for a drag
// block created for a scrollbar drag, the consequences can be fairly
Expand Down Expand Up @@ -147,12 +140,6 @@ bool InputBlockState::IsTargetConfirmed() const {
return mTargetConfirmed != TargetConfirmationState::eUnconfirmed;
}

bool InputBlockState::HasReceivedRealConfirmedTarget() const {
return mTargetConfirmed == TargetConfirmationState::eConfirmed ||
mTargetConfirmed ==
TargetConfirmationState::eTimedOutAndMainThreadResponded;
}

bool InputBlockState::ShouldDropEvents() const {
return mRequiresTargetConfirmation &&
(mTargetConfirmed != TargetConfirmationState::eConfirmed);
Expand Down
2 changes: 0 additions & 2 deletions gfx/layers/apz/src/InputBlockState.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ class InputBlockState : public RefCounted<InputBlockState> {
enum class TargetConfirmationState : uint8_t {
eUnconfirmed,
eTimedOut,
eTimedOutAndMainThreadResponded,
eConfirmed
};

Expand All @@ -73,7 +72,6 @@ class InputBlockState : public RefCounted<InputBlockState> {
uint64_t GetBlockId() const;

bool IsTargetConfirmed() const;
bool HasReceivedRealConfirmedTarget() const;

virtual bool ShouldDropEvents() const;

Expand Down

0 comments on commit 1148d52

Please sign in to comment.