Bug 1564391 - Deprecate mozInputSource and initMouseEvent. r=emilio,d…

…evtools-reviewers,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D182293
Thaodan · Jul 10, 2023 · bc6660a · bc6660a
1 parent f03ce34
commit bc6660a
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 1 deletion.
diff --git a/devtools/server/actors/webconsole/webidl-unsafe-getters-names.js b/devtools/server/actors/webconsole/webidl-unsafe-getters-names.js
@@ -9,6 +9,7 @@
 module.exports = [
   "InstallTrigger",
   "farthestViewportElement",
+  "mozInputSource",
   "mozPreservesPitch",
   "mozPressure",
   "nearestViewportElement",

diff --git a/dom/base/nsDeprecatedOperationList.h b/dom/base/nsDeprecatedOperationList.h
@@ -44,6 +44,9 @@ DEPRECATED_OPERATION(MozfullscreenchangeDeprecatedPrefix)
 DEPRECATED_OPERATION(MozfullscreenerrorDeprecatedPrefix)
 DEPRECATED_OPERATION(External_AddSearchProvider)
 DEPRECATED_OPERATION(MouseEvent_MozPressure)
+DEPRECATED_OPERATION(MozInputSource)
+DEPRECATED_OPERATION(InitMouseEvent)
+DEPRECATED_OPERATION(InitNSMouseEvent)
 DEPRECATED_OPERATION(MathML_DeprecatedMathSizeValue)
 DEPRECATED_OPERATION(MathML_DeprecatedMathSpaceValue)
 DEPRECATED_OPERATION(MathML_DeprecatedMfencedElement)

diff --git a/dom/locales/en-US/chrome/dom/dom.properties b/dom/locales/en-US/chrome/dom/dom.properties
@@ -379,8 +379,16 @@ MozfullscreenchangeDeprecatedPrefixWarning=onmozfullscreenchange is deprecated.
 MozfullscreenerrorDeprecatedPrefixWarning=onmozfullscreenerror is deprecated.
 # LOCALIZATION NOTE(External_AddSearchProviderWarning): Do not translate AddSearchProvider.
 External_AddSearchProviderWarning=AddSearchProvider is deprecated.
+
 # LOCALIZATION NOTE: Do not translate "MouseEvent.mozPressure" and "PointerEvent.pressure".
 MouseEvent_MozPressureWarning=MouseEvent.mozPressure is deprecated. Use PointerEvent.pressure instead.
+# LOCALIZATION NOTE: Do not translate "MouseEvent.mozInputSource" and "PointerEvent.pointerType".
+MozInputSourceWarning=MouseEvent.mozInputSource is deprecated. Use PointerEvent.pointerType instead.
+# LOCALIZATION NOTE: Do not translate "initMouseEvent()" and "MouseEvent()".
+InitMouseEventWarning=initMouseEvent() is deprecated. Use the MouseEvent() constructor instead.
+# LOCALIZATION NOTE: Do not translate "initNSMouseEvent()" and "MouseEvent()".
+InitNSMouseEventWarning=initNSMouseEvent() is deprecated. Use the MouseEvent() constructor instead.
+
 # LOCALIZATION NOTE: Do not translate small, normal, big and mathsize.
 MathML_DeprecatedMathSizeValueWarning=“small”, “normal” and “big” are deprecated values for the mathsize attribute and will be removed at a future date.
 # LOCALIZATION NOTE: Do not translate veryverythinmathspace, verythinmathspace,

diff --git a/dom/webidl/MouseEvent.webidl b/dom/webidl/MouseEvent.webidl
@@ -51,7 +51,8 @@ interface MouseEvent : UIEvent {
   readonly attribute long           movementY;
 
   // Deprecated in DOM Level 3:
-undefined initMouseEvent(DOMString typeArg,
+  [Deprecated="InitMouseEvent"]
+  undefined initMouseEvent(DOMString typeArg,
                          optional boolean canBubbleArg = false,
                          optional boolean cancelableArg = false,
                          optional Window? viewArg = null,
@@ -92,6 +93,7 @@ partial interface MouseEvent
 {
   // Finger or touch pressure event value
   // ranges between 0.0 and 1.0
+  // TODO: Remove mozPressure. (bug 1534199)
   [Deprecated="MouseEvent_MozPressure"]
   readonly attribute float mozPressure;
 
@@ -103,8 +105,11 @@ partial interface MouseEvent
   const unsigned short    MOZ_SOURCE_TOUCH      = 5;
   const unsigned short    MOZ_SOURCE_KEYBOARD   = 6;
 
+  [Deprecated="MozInputSource"]
   readonly attribute unsigned short mozInputSource;
 
+  // TODO: Remove initNSMouseEvent. (bug 1165213)
+  [Deprecated="InitNSMouseEvent"]
   undefined initNSMouseEvent(DOMString typeArg,
                              optional boolean canBubbleArg = false,
                              optional boolean cancelableArg = false,