forked from oracle/graal
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow Array.set(objArray, index, null) to not throw NPE.
Fixes oracle#1585 Avoid checking assignability of the value to the array element type if the value is null, and therefore `.getClass()` is pretty much guaranteed to throw an NPE. (cherry picked from commit 28ff8a1)
- Loading branch information
1 parent
856c93d
commit 8a9fb51
Showing
2 changed files
with
56 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
substratevm/src/com.oracle.svm.test/src/com/oracle/svm/test/ArraySetTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/* | ||
* Copyright (c) 2019, 2019, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. Oracle designates this | ||
* particular file as subject to the "Classpath" exception as provided | ||
* by Oracle in the LICENSE file that accompanied this code. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
package com.oracle.svm.test; | ||
|
||
// Checkstyle: off | ||
import java.lang.reflect.Array; | ||
|
||
import org.junit.Assert; | ||
import org.junit.Test; | ||
|
||
public class ArraySetTest { | ||
|
||
@Test | ||
public void testObjectArraySetWithNull() { | ||
String[] array = new String[]{ | ||
"a", | ||
"b", | ||
"c", | ||
"d" | ||
}; | ||
|
||
Array.set(array, 0, null); | ||
|
||
Assert.assertNull(array[0]); | ||
Assert.assertEquals("b", array[1]); | ||
Assert.assertEquals("c", array[2]); | ||
Assert.assertEquals("d", array[3]); | ||
} | ||
|
||
} |