Fixes The Bug In Radix Tree. Issue #11316 #11385
Conversation
covid-in
changed the title
for more information, see https://pre-commit.ci
Based on ruff Recommendations
- Removed WhiteSpaces
- Moved the Import to beginning
- Replaced assertTrue with regular assert
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
tests are failing
|
Hey @spazm. Can you please review this PR. Radix Tree had a bug. And Excuse me for the commit mess. Ruff gave me some problems |
| @@ -1,3 +1,5 @@ | |||
| import unittest | |||
There was a problem hiding this comment.
We (and the majority of the Python community) use pytest instead of unittest so all this boilerplate is not needed.
As discussed in CONTRIBUTING.md, changing both code and tests in a single pull request makes code review quite difficult.
Can you please create a separate simple pull request that adds a test that proves that word = "" fails?
Once that is proven, we can determine how to proceed with this pull request.
There was a problem hiding this comment.
It fails on subseunt recursive calls not on direct addition of "". Please check the issue it is trying to fix. I have added the same word insertions in Unit Test as well
|
|
||
| class TestRadixNode(unittest.TestCase): |
There was a problem hiding this comment.
This boilerplate adds unnecessary complexity.
There was a problem hiding this comment.
Sure Will Remove it. But its the best way to do this
Describe your change:
Fixes #11316 .
There is a bug in the code which doesn't handle the edge case when the insertion of empty string is done.
Checklist: