Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added star delta converter module #9649

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

added star delta converter module #9649

wants to merge 9 commits into from

Conversation

Yosef-6
Copy link

@Yosef-6 Yosef-6 commented Oct 3, 2023

Describe your change:

Added a new module to electronics directory

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 3, 2023
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 3, 2023
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 3, 2023
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 3, 2023
rohan472000
rohan472000 reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@rohan472000 rohan472000 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only DC, how about including AC resistors examples???

@Yosef-6
Copy link
Author

Yosef-6 commented Oct 4, 2023

ok working on it including impedances to make it general

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 4, 2023
@rohan472000
Copy link
Contributor

Still the real part is working, you need to find angle between real and imaginary, then find star-delta.

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 4, 2023
@Yosef-6
Copy link
Author

Yosef-6 commented Oct 4, 2023 •
edited
Loading

I didn't understand sir why do I have to convert the impedances into polar form while that is handled internally by the division, multiplication operator on complex numbers in python meaning its same even if I converted to polar and then do the operations.

@Yosef-6 Yosef-6 requested a review from rohan472000 October 4, 2023 18:46
@rohan472000
Copy link
Contributor

Yes ..i didn't know about this feature of the complex type in python.

@Yosef-6
Copy link
Author

Yosef-6 commented Oct 5, 2023

Thanks sir
could you take a look at this pr #9535 am an electrical engineer am developing the electronics directory

@Yosef-6 Yosef-6 closed this Oct 7, 2023
@Yosef-6 Yosef-6 reopened this Oct 7, 2023
@Yosef-6
Copy link
Author

Yosef-6 commented Oct 7, 2023

why is this pr not merging after being aproved rohan472000 ?

@Yosef-6 Yosef-6 requested a review from rohan472000 October 7, 2023 06:12
@rohan472000
Copy link
Contributor

why is this pr not merging after being aproved rohan472000 ?

Repo maintainer will also review and then only it will be merged.

@Yosef-6
Copy link
Author

Yosef-6 commented Oct 7, 2023

why is this pr not merging after being aproved rohan472000 ?

Repo maintainer will also review and then only it will be merged.

Got it 👍 am new to git and open source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohan472000 rohan472000 Awaiting requested review from rohan472000

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yosef-6 @rohan472000