Remove nth node from end of list #9880

aryandgandhi · 2023-10-05T23:23:44Z

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

… remove_nth_node_from_end_of_list Merging latest changes from upstream master into my feature branch. :wq

… remove_nth_node_from_end_of_list Merging branch master with remove_nth branch

…list

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2023-10-05T23:23:50Z

data_structures/linked_list/remove_nth_node_from_end_of_list.py

+
+
+class LinkedList:
+    def __init__(self):


Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:

data_structures/linked_list/remove_nth_node_from_end_of_list.py

algorithms-keeper · 2023-10-05T23:23:51Z

data_structures/linked_list/remove_nth_node_from_end_of_list.py

+            temp = temp.next
+        return ret[:-2]
+
+    def remove_nth_from_end(self, n: int) -> Node | None:


Please provide descriptive name for the parameter: n

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2023-10-05T23:40:02Z

data_structures/linked_list/remove_nth_node_from_end_of_list.py

+
+
+class LinkedList:
+    def __init__(self):


Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:

… remove_nth_node_from_end_of_list combine the latest commit

… remove_nth_node_from_end_of_list merging new change

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2023-10-06T00:15:20Z

data_structures/linked_list/remove_nth_node_from_end_of_list.py

+
+
+class LinkedList:
+    def __init__(self):  # type: ignore


Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:

cclauss · 2023-10-06T00:40:34Z

data_structures/linked_list/remove_nth_node_from_end_of_list.py

+
+
+class LinkedList:
+    def __init__(self):  # type: ignore


Suggested change

def __init__(self): # type: ignore

def __init__(self) -> None:

You will save a lot of code if you create .__iter__() and .__len__() methods like in

Python/data_structures/linked_list/singly_linked_list.py

Line 37 in 17af644

def __iter__(self) -> Any:

I'll keep this in mind moving forward and take a look at thos.

cclauss · 2023-10-06T00:45:08Z

data_structures/linked_list/remove_nth_node_from_end_of_list.py

+class Node:
+    def __init__(self, data: int) -> None:
+        self.data = data
+        self.next = None


Please make Node a dataclass.

Python/data_structures/linked_list/print_reverse.py

Lines 4 to 10 in 17af644

from dataclasses import dataclass

@dataclass

class Node:

data: int

next_node: Node | None = None

cclauss · 2023-10-06T00:48:45Z

data_structures/linked_list/remove_nth_node_from_end_of_list.py

+        # We could complete this in one pass if we stored a self.size variable
+
+        if not self.head:
+            print("No element found.")


CONTRIBUTING.md. Algorithmic functions do not print(). Please raise an IndexError. There are plenty of examples in this repo of raising Exceptions and creating tests for them.

tianyizheng02

Why add an entirely new file (with an entirely separate linked list implementation) for this feature? Why not add a function within one of the existing linked list implementations instead?

aryandgandhi · 2023-10-06T02:26:27Z

Why add an entirely new file (with an entirely separate linked list implementation) for this feature? Why not add a function within one of the existing linked list implementations instead?

I think it's a good algorithm to have by itself + I plan on adding a couple more implementations for different time and space complexity

aryandgandhi · 2023-10-07T17:36:05Z

@cclauss please approve this PR for hacktoberfest and add the hacktoberfest-accepted label after PR merging. Thank you!

aryandgandhi and others added 6 commits October 5, 2023 17:36

removed nth node

00b94bb

Merge branch 'master' of https://github.com/TheAlgorithms/Python into…

c39cf50

… remove_nth_node_from_end_of_list Merging latest changes from upstream master into my feature branch. :wq

added link to learn about algo

0993fb4

Merge branch 'master' of https://github.com/TheAlgorithms/Python into…

b1b6271

… remove_nth_node_from_end_of_list Merging branch master with remove_nth branch

Addressed PR feedback

2214c0d

Merge branch 'TheAlgorithms:master' into remove_nth_node_from_end_of_…

3bfe23a

…list

algorithms-keeper bot added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 5, 2023

algorithms-keeper bot reviewed Oct 5, 2023

View reviewed changes

algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 5, 2023

update bot comments

d8ec9d4

algorithms-keeper bot removed require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required labels Oct 5, 2023

algorithms-keeper bot reviewed Oct 5, 2023

View reviewed changes

aryandgandhi added 3 commits October 5, 2023 18:48

Merge branch 'master' of https://github.com/TheAlgorithms/Python into…

1ed3e7f

… remove_nth_node_from_end_of_list combine the latest commit

update type

892f7c5

Merge branch 'master' of https://github.com/TheAlgorithms/Python into…

15b8a14

… remove_nth_node_from_end_of_list merging new change

algorithms-keeper bot reviewed Oct 6, 2023

View reviewed changes

cclauss reviewed Oct 6, 2023

View reviewed changes

new branch

64a9452

algorithms-keeper bot removed the require type hints https://docs.python.org/3/library/typing.html label Oct 6, 2023

aryandgandhi added 3 commits October 5, 2023 20:04

new branch

9e31192

latest updates with typing

2fe0897

latest updates with typing

e13fefc

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 6, 2023

tianyizheng02 reviewed Oct 6, 2023

View reviewed changes

aryandgandhi requested review from cclauss and tianyizheng02 October 6, 2023 15:52

This was referenced Oct 22, 2023

trapzoidal doctest closes #9943 #10790

Closed

Trapezoid closes #9943 #10792

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove nth node from end of list #9880

Remove nth node from end of list #9880

aryandgandhi commented Oct 5, 2023 •

edited

Loading

algorithms-keeper bot left a comment

algorithms-keeper bot Oct 5, 2023

algorithms-keeper bot Oct 5, 2023

algorithms-keeper bot left a comment

algorithms-keeper bot Oct 5, 2023

algorithms-keeper bot left a comment

algorithms-keeper bot Oct 6, 2023

cclauss Oct 6, 2023

cclauss Oct 6, 2023

aryandgandhi Oct 6, 2023

cclauss Oct 6, 2023

cclauss Oct 6, 2023

tianyizheng02 left a comment

aryandgandhi commented Oct 6, 2023

aryandgandhi commented Oct 7, 2023

	def __init__(self): # type: ignore
	def __init__(self) -> None:

	from dataclasses import dataclass


	@dataclass
	class Node:
	data: int
	next_node: Node \| None = None

Remove nth node from end of list #9880

Are you sure you want to change the base?

Remove nth node from end of list #9880

Conversation

aryandgandhi commented Oct 5, 2023 • edited Loading

Describe your change:

Checklist:

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot Oct 5, 2023

Choose a reason for hiding this comment

algorithms-keeper bot Oct 5, 2023

Choose a reason for hiding this comment

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot Oct 5, 2023

Choose a reason for hiding this comment

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot Oct 6, 2023

Choose a reason for hiding this comment

cclauss Oct 6, 2023

Choose a reason for hiding this comment

cclauss Oct 6, 2023

Choose a reason for hiding this comment

aryandgandhi Oct 6, 2023

Choose a reason for hiding this comment

cclauss Oct 6, 2023

Choose a reason for hiding this comment

cclauss Oct 6, 2023

Choose a reason for hiding this comment

tianyizheng02 left a comment

Choose a reason for hiding this comment

aryandgandhi commented Oct 6, 2023

aryandgandhi commented Oct 7, 2023

aryandgandhi commented Oct 5, 2023 •

edited

Loading