Skip to content

Commit

Permalink
Migrate to use the published metrics_center (flutter#23767)
Browse files Browse the repository at this point in the history
This change shouldn't affect anything except for the "Linux benchmarks" LUCI post-submit bot.

We'll closely monitor the LUCI bot to see if this works as intended. If so, we'll continue the migration in Cocoon (flutter/cocoon#1062) to cut the dependency on the old Cocoon datastore and Tong's desktop.

Related issue: flutter/flutter#73872
  • Loading branch information
liyuqian authored Jan 20, 2021
1 parent c97bdae commit 6182497
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
3 changes: 1 addition & 2 deletions testing/benchmark/bin/parse_and_send.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ import 'dart:convert';
import 'dart:io';

import 'package:git/git.dart';
import 'package:metrics_center/flutter.dart';
import 'package:metrics_center/google_benchmark.dart';
import 'package:metrics_center/metrics_center.dart';

Future<String> _getGitRevision() async {
final GitDir gitDir = await GitDir.fromExisting('../../');
Expand Down
6 changes: 2 additions & 4 deletions testing/benchmark/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,8 @@ name: flutter_engine_benchmark

dependencies:
git: any
metrics_center:
# TODO(liyuqian): once metrics_center is properly reviewed, add it to
# flutter/packages, publish on pub.dev, and use the published package here.
git: https://github.com/liyuqian/metrics_center.git

metrics_center: 0.0.4

dev_dependencies:
test: any
Expand Down

0 comments on commit 6182497

Please sign in to comment.