[MA-225][DNO-95] remove message loop handlers when destroying VulkanS…

…urfaceProducer to avoid callbacks on deleted pointers (flutter#3733)
TheDauntless · Jun 2, 2017 · e954e2f · e954e2f
1 parent bd09286
commit e954e2f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/content_handler/vulkan_rasterizer.cc b/content_handler/vulkan_rasterizer.cc
@@ -52,6 +52,12 @@ VulkanRasterizer::VulkanSurfaceProducer::VulkanSurfaceProducer() {
     FTL_LOG(ERROR) << "VulkanSurfaceProducer failed to initialize";
 }
 
+VulkanRasterizer::VulkanSurfaceProducer::~VulkanSurfaceProducer() {
+  for (auto &surface_info : pending_surfaces_)
+    mtl::MessageLoop::GetCurrent()->RemoveHandler(
+        surface_info.second.handler_key);
+}
+
 std::unique_ptr<VulkanRasterizer::VulkanSurfaceProducer::Surface>
 VulkanRasterizer::VulkanSurfaceProducer::CreateSurface(uint32_t width,
                                                        uint32_t height) {

diff --git a/content_handler/vulkan_rasterizer.h b/content_handler/vulkan_rasterizer.h
@@ -39,6 +39,7 @@ class VulkanRasterizer : public Rasterizer {
         private mtl::MessageLoopHandler {
    public:
     VulkanSurfaceProducer();
+    ~VulkanSurfaceProducer() override;
     sk_sp<SkSurface> ProduceSurface(SkISize size,
                                     mozart::ImagePtr* out_image) override;