Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Solid support #35

Closed
wants to merge 3 commits into from
Closed

Add Solid support #35

wants to merge 3 commits into from

Conversation

brandonpittman
Copy link
Contributor

@brandonpittman brandonpittman commented Jul 13, 2023 •
edited
Loading

@TheMightyPenguin Hey there! Got a PR for you.

Goal

This PR will add Solid support with the same API as the React package.

Concerns

  • I saw errors in a Solid Start (Vite) app with the TS target set to es5. When set to at least es2015, the errors went away.
  • I changed a types a bit, but the hints in the editor all seem okay.

fixes #7

@brandonpittman brandonpittman marked this pull request as ready for review July 13, 2023 08:50
@brandonpittman brandonpittman deleted the feat/solidjs branch July 20, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Solid Js
1 participant
@brandonpittman