-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: iOS constraints when controls are enabled and video is inside a ScrollView #4383
base: master
Are you sure you want to change the base?
fix: iOS constraints when controls are enabled and video is inside a ScrollView #4383
Conversation
@freeboub I messed up the rebase/fork sync 😢 , wtf webstorm.... let me know if you want to ditch this PR and create a new clean one |
I don't care, if you prefer to open a new one, it is ok for me ! |
@freeboub ok then, this is g2g. Thank you for looking into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
63d719e
to
51ca930
Compare
@KrzysztofMoch hi, just rebased, checks are fine, no kotlin checks fired 👍 |
Fixes:
Summary
It seems that going from AVPlayerLayer to AVPlayerViewController when controls are enabled breaks the layout. By manually setting the constraints it keeps the size/position intact.