improving Exception messages for BatchSize and FlushTimeout

TheeJamesLee · Jul 3, 2017 · 25dcfef · 25dcfef
1 parent 9ac4e2a
commit 25dcfef
Showing 1 changed file with 6 additions and 14 deletions.
diff --git a/...oft.Azure.WebJobs.Host/Loggers/Logger/Aggregator/FunctionResultAggregatorConfiguration.cs b/...oft.Azure.WebJobs.Host/Loggers/Logger/Aggregator/FunctionResultAggregatorConfiguration.cs
@@ -44,14 +44,10 @@ public int BatchSize
 
             set
             {
-                if (value <= 0)
+                if (value <= 0 || value > MaxBatchSize)
                 {
-                    throw new ArgumentOutOfRangeException(nameof(value));
-                }
-
-                if (value > MaxBatchSize)
-                {
-                    throw new ArgumentOutOfRangeException(nameof(value));
+                    string message = $"'{nameof(BatchSize)}' value must be greater than 0 and less than or equal to {MaxBatchSize}.";
+                    throw new ArgumentOutOfRangeException(null, value, message);
                 }
 
                 _batchSize = value;
@@ -67,14 +63,10 @@ public TimeSpan FlushTimeout
 
             set
             {
-                if (value <= TimeSpan.Zero)
-                {
-                    throw new ArgumentOutOfRangeException(nameof(value));
-                }
-
-                if (value > MaxFlushTimeout)
+                if (value <= TimeSpan.Zero || value > MaxFlushTimeout)
                 {
-                    throw new ArgumentOutOfRangeException(nameof(value));
+                    string message = $"'{nameof(FlushTimeout)}' value must be greater than '{TimeSpan.Zero.ToString()}' and less than or equal to '{MaxFlushTimeout.ToString()}'.";
+                    throw new ArgumentOutOfRangeException(null, value, message);
                 }
 
                 _flushTimeout = value;