WP stories #1973

GunkaArtur · 2024-01-25T11:20:53Z

Related issue https://github.com/bagrinsergiu/blox-editor/issues/25400

victor-pg · 2024-02-07T06:56:01Z

public/editor-client/src/types/DefaultTemplate.ts

+  stories: Array<StoriesTemplateWithThumbs>;
+}
+
+export type StoriesAPI = {


convert to interface

victor-pg · 2024-02-07T06:56:05Z

public/editor-client/src/types/DefaultTemplate.ts

+  thumbnailHeight: number;
+}
+
+export type StoryPages = {


convert to interface

victor-pg · 2024-02-07T06:56:52Z

public/editor-client/src/defaultTemplates/utils.ts

+            project: id,
+            name: title,
+            cat: categories.split(",").map((cat) => cat.trim()),
+            color: "#d7fb00",


it is ok this color to be hardcoded ?

We have some parts that are temporary hardcoded, color and styles, in future we will fix it

victor-pg · 2024-02-07T06:59:14Z

public/editor-client/src/defaultTemplates/tempConverters.ts

-        categories: kit.categories,
-        types: kit.types as KitType[]
+      blank,
+      project: blank ? pages[0].id : name,


move pages[0] in some const and if you have an parser for page, then use it

const page = parser(pages[0]);

victor-pg · 2024-02-07T06:59:54Z

public/editor-client/src/defaultTemplates/tempConverters.ts

+      thumbnailHeight,
+      thumbnailWidth,
+      thumbnailSrc: `${url}/${id}.jpg`,
+      pro: pro ?? false,


victor-pg · 2024-02-07T07:01:36Z

public/editor-client/src/defaultTemplates/tempConverters.ts

+      styles,
+      pro: isPro,
+      thumbnailSrc: `${thumbUrl}/${pages[0].id}.jpg`,
+      thumbnailWidth: pages[0].thumbnailWidth,


same here, move pages[0] in some const

this is Layout converter and will be fixed in Layout PR

victor-pg · 2024-04-24T05:39:00Z

public/editor-client/src/api/index.ts

+  return Json.read(data[0].pageData) as {
+    items: DefaultBlockWithID[];
+  };


remove casting, because of casting we don't handle some errors

as example here Json.read can return undefined

but you cast is as object with items inside

victor-pg · 2024-04-24T05:39:22Z

public/editor-client/src/api/index.ts

+    `${url}/get-story-page-data?project_id=${layoutId}&page_slug=${id}`
+  ).then((r) => r.json());
+
+  const pageData = JSON.parse(data.collection);


use Json.read or wrap in try/catch json parsing

victor-pg · 2024-04-24T05:40:22Z

public/editor-client/src/api/index.ts

+  return pageData as {
+    blocks: DefaultBlock[];
+  };


remove casting

if without casting is not possible then validate it, as example if pageData will be undefined/null then return empty array

victor-pg · 2024-04-24T05:42:09Z

public/editor-client/src/defaultTemplates/utils.ts

+        name: title,
+        cat: categories.split(",").map((item) => item.trim()),
+        color,
+        pagesCount: Number(pagesCount),


better use Num.read instead of Number(pagesCount), because Number() can return NaN

victor-pg · 2024-04-24T05:42:36Z

public/editor-client/src/defaultTemplates/utils.ts

+        cat: categories.length
+          ? categories.split(",").map((cat) => cat.trim())
+          : [],
+        color: color,


write short: color: color -> color

victor-pg · 2024-04-24T05:43:44Z

public/editor-client/src/defaultTemplates/utils.ts

-  return allElements;
-};
+export function convertToCategories(obj: Record<string, string>): Categories[] {
+  return Object.entries(obj).map(([_, title]) => ({


use Object.value(obj) instead of Object.entries(obj) to void using of _ for skip an variable

GunkaArtur · 2024-07-08T11:19:23Z

new PR on beta #2004

GunkaArtur self-assigned this Jan 25, 2024

GunkaArtur force-pushed the 25299-layoutsToAPI branch 3 times, most recently from e86cad6 to 4c15761 Compare February 5, 2024 09:29

GunkaArtur force-pushed the 25400-WP-stories branch 2 times, most recently from 459f77b to 21a819b Compare February 6, 2024 08:25

victor-pg requested changes Feb 7, 2024

View reviewed changes

GunkaArtur force-pushed the 25299-layoutsToAPI branch from 4c15761 to 46a2245 Compare February 7, 2024 10:03

GunkaArtur force-pushed the 25400-WP-stories branch 3 times, most recently from 70ae191 to a4246a6 Compare February 7, 2024 12:11

GunkaArtur force-pushed the 25299-layoutsToAPI branch 3 times, most recently from 3391208 to 20feb9d Compare February 14, 2024 13:35

GunkaArtur force-pushed the 25400-WP-stories branch 4 times, most recently from 376a03f to 75a4ae8 Compare February 19, 2024 11:47

GunkaArtur force-pushed the 25299-layoutsToAPI branch 2 times, most recently from ec4a20a to ed86dcd Compare February 22, 2024 11:43

GunkaArtur force-pushed the 25400-WP-stories branch 3 times, most recently from f8af8c4 to 2ff72cc Compare February 26, 2024 12:53

GunkaArtur force-pushed the 25299-layoutsToAPI branch from ed86dcd to 1cc7e37 Compare February 26, 2024 13:49

GunkaArtur force-pushed the 25400-WP-stories branch 2 times, most recently from 86b3bc9 to 1388183 Compare February 26, 2024 13:54

GunkaArtur force-pushed the 25299-layoutsToAPI branch 2 times, most recently from ff5d56a to f10764f Compare March 12, 2024 13:59

GunkaArtur force-pushed the 25400-WP-stories branch 2 times, most recently from 7341a4d to b28625c Compare March 13, 2024 08:46

GunkaArtur force-pushed the 25299-layoutsToAPI branch 2 times, most recently from ca90731 to 0e8026a Compare March 26, 2024 12:18

GunkaArtur force-pushed the 25400-WP-stories branch 3 times, most recently from 9319590 to a9b7fd9 Compare March 27, 2024 13:32

GunkaArtur force-pushed the 25400-WP-stories branch from 13d3a03 to e492873 Compare April 16, 2024 11:57

GunkaArtur force-pushed the 25299-layoutsToAPI branch from 10b656c to 7857acb Compare April 17, 2024 07:19

GunkaArtur force-pushed the 25400-WP-stories branch 2 times, most recently from 8421056 to 000c60f Compare April 23, 2024 10:19

GunkaArtur force-pushed the 25299-layoutsToAPI branch 2 times, most recently from 6718ed2 to 43677e1 Compare April 23, 2024 12:55

victor-pg requested changes Apr 24, 2024

View reviewed changes

GunkaArtur force-pushed the 25400-WP-stories branch 2 times, most recently from 26f635a to 6d25b21 Compare May 27, 2024 08:23

GunkaArtur force-pushed the 25299-layoutsToAPI branch from 6522cff to 47e9acc Compare June 3, 2024 07:39

connect to layouts to API

c69f859

GunkaArtur force-pushed the 25299-layoutsToAPI branch from 52ba1ab to c69f859 Compare June 4, 2024 11:59

GunkaArtur force-pushed the 25400-WP-stories branch from 6d25b21 to e080c51 Compare June 5, 2024 12:47

connect to layouts to API

d51ca87

GunkaArtur force-pushed the 25400-WP-stories branch from e080c51 to d51ca87 Compare June 5, 2024 12:57

GunkaArtur force-pushed the 25299-layoutsToAPI branch 7 times, most recently from 7374952 to f0686f3 Compare July 2, 2024 08:24

GunkaArtur closed this Jul 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WP stories #1973

WP stories #1973

GunkaArtur commented Jan 25, 2024

victor-pg Feb 7, 2024

victor-pg Feb 7, 2024

victor-pg Feb 7, 2024

GunkaArtur Feb 7, 2024

victor-pg Feb 7, 2024

victor-pg Feb 7, 2024

victor-pg Feb 7, 2024

GunkaArtur Feb 7, 2024

victor-pg Apr 24, 2024

victor-pg Apr 24, 2024

victor-pg Apr 24, 2024

victor-pg Apr 24, 2024

victor-pg Apr 24, 2024

victor-pg Apr 24, 2024

GunkaArtur commented Jul 8, 2024

WP stories #1973

WP stories #1973

Conversation

GunkaArtur commented Jan 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GunkaArtur commented Jul 8, 2024