Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed editor bootstrap #390

Merged
merged 2 commits into from
Jul 25, 2018
Merged

Changed editor bootstrap #390

merged 2 commits into from
Jul 25, 2018

Conversation

rockalife
Copy link
Contributor

This PR does the following:

  1. The loader now does not load brizy-init that bootstraps the editor. Instead it enqueues all the styles and scripts via wp_enqueue_style and wp_enqueue_script. This is done to be more "WordPressy" and also for the upcoming pro version.
  2. I have removed from public/editor-build the version folder (e.g., 1.0.44) and moved all the assets directly in public/editor-build. The version is now added via wp_enqueue_style and wp_enqueue_script

@rockalife rockalife requested a review from alecszaharia July 25, 2018 12:05
@rockalife rockalife assigned rockalife and unassigned alecszaharia Jul 25, 2018
@alecszaharia alecszaharia merged commit c75d35b into develop Jul 25, 2018
@alecszaharia alecszaharia deleted the change-bootstrap-2 branch July 25, 2018 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecszaharia alecszaharia Awaiting requested review from alecszaharia

Assignees

@rockalife rockalife

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rockalife @alecszaharia