feat(util): add cache for users name. First startup of plugin my take some time

Author: TheoSarrazin

lua/glpi/api.lua

@@ -1,5 +1,6 @@
 local curl = require("plenary.curl")
 local config = require("glpi.config")
+local utils = require("glpi.utils")
 local M = {}
 
 M.options = {
@@ -167,26 +168,36 @@ local function get_user(user_id)
 end
 
 local function get_username(user_id)
+	local user_name = utils.get_user_in_cache(user_id)
+
+	if user_name ~= nil then
+		return user_name
+	end
+
 	local user = get_user(user_id)
 	local firstname = user["firstname"]
 	local lastname = user["realname"]
-	return lastname .. " " .. firstname
+	user_name = lastname .. " " .. firstname
+	utils.add_user_to_cache(user_id, user_name)
+	utils.write_user_cache()
+
+	return user_name
 end
 
 local function search_tickets(opts)
 	opts = opts or {}
 
-	local type = opts.type or "new"
+	local ticket_type = opts.type or "new"
 
 	local crit = {}
 
-	if type == "new" then
+	if ticket_type == "new" then
 		table.insert(crit, {
 			field = 12,
 			value = 1,
 			searchtype = "equals",
 		})
-	elseif type == "my_pending" then
+	elseif ticket_type == "my_pending" then
 		table.insert(crit, {
 			field = 5,
 			value = M.options.user_id,
@@ -203,7 +214,7 @@ local function search_tickets(opts)
 				},
 			},
 		})
-	elseif type == "my_processing" then
+	elseif ticket_type == "my_processing" then
 		table.insert(crit, {
 			field = 5,
 			value = M.options.user_id,
@@ -220,7 +231,7 @@ local function search_tickets(opts)
 				},
 			},
 		})
-	elseif type == "my" then
+	elseif ticket_type == "my" then
 		table.insert(crit, {
 			field = 5,
 			value = M.options.user_id,
@@ -243,7 +254,7 @@ local function search_tickets(opts)
 				},
 			},
 		})
-	elseif type == "other" then
+	elseif ticket_type == "other" then
 		table.insert(crit, {
 			field = 5,
 			value = M.options.user_id,
@@ -274,9 +285,24 @@ local function search_tickets(opts)
 		return nil
 	end
 
+	local function parse_usernames(users)
+		if type(users) == "string" then
+			return get_username(users)
+		end
+
+		local names = {}
+		for _, user in ipairs(users) do
+			table.insert(names, get_username(user))
+		end
+		return names
+	end
+
 	for i, _ in ipairs(tickets) do
 		local status = get_status(tickets[i]["12"])
 		tickets[i]["12"] = status
+
+		tickets[i]["4"] = parse_usernames(tickets[i]["4"])
+		tickets[i]["5"] = parse_usernames(tickets[i]["5"])
 	end
 
 	return tickets

lua/glpi/init.lua

@@ -1,6 +1,7 @@
 local config = require("glpi.config")
 local view = require("glpi.view")
 local api = require("glpi.api")
+local utils = require("glpi.utils")
 
 local M = {}
 
@@ -45,6 +46,7 @@ end
 
 function M.setup(opts)
 	config.setup(opts)
+    utils.setup()
 
 	vim.keymap.set("n", config.keymaps.reload_ticket, reload_tickets, {})
 	vim.keymap.set("n", config.keymaps.toggle_separation, function()

lua/glpi/utils.lua

@@ -0,0 +1,37 @@
+local path = require("plenary.path")
+
+local M = {}
+
+local data_path = path:new(vim.fn.stdpath("data") .. "/glpi")
+local user_cache_file = path:new(data_path):joinpath("user_cache.json")
+
+local user_cache = {}
+
+function M.setup()
+	if not data_path:exists() then
+		data_path:mkdir({ parent = true })
+	end
+
+	if not user_cache_file:exists() then
+		user_cache = {}
+		return
+	end
+
+	local content = user_cache_file:read()
+	user_cache = content ~= nil and vim.json.decode(content) or {}
+end
+
+function M.get_user_in_cache(user_id)
+	return user_cache[tostring(user_id)]
+end
+
+function M.add_user_to_cache(user_id, user_name)
+	user_cache[tostring(user_id)] = user_name
+end
+
+function M.write_user_cache()
+	local content = vim.json.encode(user_cache)
+	user_cache_file:write(content, "w")
+end
+
+return M

lua/glpi/view.lua

@@ -166,7 +166,10 @@ local function format_tickets_view(tickets)
 			table.insert(lines, "# " .. title .. " (" .. #tickets_list .. ")")
 			table.insert(lines, "")
 			for _, ticket in ipairs(tickets_list) do
-				table.insert(lines, "- " .. ticket["1"] .. " (" .. ticket["12"] .. ")")
+				local ticket_4 = ticket["4"]
+				local name = type(ticket_4) == "table" and ticket_4[1] or ticket_4
+
+				table.insert(lines, "- " .. ticket["1"] .. " (" .. ticket["12"] .. " | " .. name .. ")")
 			end
 			table.insert(lines, "")
 			table.insert(lines, "")

lua/telescope/_extensions/glpi/tickets.lua

@@ -17,7 +17,7 @@ local function get_tickets()
 	local function extract_ticket(t)
 		for _, ticket in ipairs(t) do
 			local id = ticket["2"]
-			local name = ticket["1"]
+			local name = ticket["1"] .. " (" .. ticket["4"] .. ")"
 			tickets[name] = id
 		end
 	end