Skip to content

Commit

Permalink
[crypto] Removes hasher bench
Browse files Browse the repository at this point in the history
Reasons:
- this bench is more of a test, since it compares a hash generated through a "by hand" implementation of CryptoHasher with one generated through macro. Since benches run after (static) macro expansion, those don't really have a really different performance profile.
- this bench has been in error (i.e. its assert fails) for a while!
- Cryptohasher derivation is now the one true way of obtaining hashes.

Closes: aptos-labs#5343
Approved by: davidiw
  • Loading branch information
huitseeker authored and bors-libra committed Jul 28, 2020
1 parent 719f9b2 commit 1dea02e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 56 deletions.
4 changes: 0 additions & 4 deletions crypto/crypto/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,6 @@ fuzzing = ["proptest", "proptest-derive", "cloneable-private-keys"]
fiat = ["curve25519-dalek", "ed25519-dalek", "x25519-dalek"]
vanilla = ["vanilla-curve25519-dalek", "vanilla-ed25519-dalek", "vanilla-x25519-dalek"]

[[bench]]
name = "hash"
harness = false

[[bench]]
name = "noise"
harness = false
Expand Down
52 changes: 0 additions & 52 deletions crypto/crypto/benches/hash.rs

This file was deleted.

0 comments on commit 1dea02e

Please sign in to comment.