Refactor redundant doc url logic to use utility (apache#14080)

TiDeane · Feb 9, 2021 · d2577e4 · d2577e4
1 parent 9005f28
commit d2577e4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/airflow/api_connexion/exceptions.py b/airflow/api_connexion/exceptions.py
@@ -19,15 +19,9 @@
 import werkzeug
 from connexion import FlaskApi, ProblemException, problem
 
-from airflow import version
-
-if any(suffix in version.version for suffix in ['dev', 'a', 'b']):
-    doc_link = (
-        "http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/apache-airflow/latest"
-        "/stable-rest-api-ref.html"
-    )
-else:
-    doc_link = f'https://airflow.apache.org/docs/{version.version}/stable-rest-api-ref.html'
+from airflow.utils.docs import get_docs_url
+
+doc_link = get_docs_url("stable-rest-api-ref.html")
 
 EXCEPTIONS_LINK_MAP = {
     400: f"{doc_link}#section/Errors/BadRequest",

diff --git a/airflow/utils/docs.py b/airflow/utils/docs.py
@@ -22,7 +22,7 @@
 
 def get_docs_url(page: Optional[str] = None) -> str:
     """Prepare link to Airflow documentation."""
-    if "dev" in version.version:
+    if any(suffix in version.version for suffix in ['dev', 'a', 'b']):
         result = (
             "http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/apache-airflow/latest/"
         )