Fixed JSONEditor picking the first entry of modes as initial mode i…

…nstead of option `mode`
TobyEalden · Jul 10, 2017 · 7ac3f5a · 7ac3f5a
1 parent 15ed4da
commit 7ac3f5a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/HISTORY.md b/HISTORY.md
@@ -3,6 +3,14 @@
 https://github.com/josdejong/jsoneditor
 
 
+## 2017-07-10, version 5.8.3
+
+- Fixed #429: JSONEditor no longer accepting an empty array for option
+  `modes`. Thanks @trystan2k.
+- Fixed JSONEditor picking the first entry of `modes` as initial mode
+  instead of option `mode`.
+
+
 ## 2017-07-08, version 5.8.2
 
 - Select first option from `modes` instead of `tree` when `mode` is not

diff --git a/src/js/JSONEditor.js b/src/js/JSONEditor.js
@@ -130,7 +130,7 @@ JSONEditor.prototype._create = function (container, options, json) {
   this.options = options || {};
   this.json = json || {};
 
-  var mode = this.options.modes && this.options.modes.length > 0 ? this.options.modes[0] : this.options.mode || 'tree';
+  var mode = this.options.mode || (this.options.modes && this.options.modes[0]) || 'tree';
   this.setMode(mode);
 };