Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIXEL selling and buyEnergy #706

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mschultheiss83
Copy link
Contributor

  • cleanup pixel code, sell PIXELs
  • buyEnergy if we have terminals and storage, mineral creeps should move energy to storage for builders and upgrader (see PR fixed: mineral handling #703)
  • fixed quests.js for incoming transactions

- buyEnergy if we have terminals and storage, mineral creeps should move energy to storage for builders and upgrader sell PR TooAngel#703
- fixed quests.js for incoming transactions
Copy link
Owner

@TooAngel TooAngel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Only the config changes and the default values on transcations needs to be improved or discussed.

@@ -0,0 +1,40 @@
'use strict';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the brain prefix anymore. I would just call it pixel.js

// 300M credits
minCredits: 300000000,
// 300K credits
minCredits: 300000,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have as minCredits the price of an access key, which is currently around 500M.
So we shouldn't reduce this, if you prefer you can change it in your local config.

What do you think?

*/
function checkQuestForAcceptance(transaction) {
Memory.quests = Memory.quests || {};
transaction.description = transaction.description || JSON.stringify({
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this change.
This sets the description of the transaction to some 'random' value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants