This repository has been archived by the owner on Dec 9, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Disk space check / download precentage correction / shutdown process / Players tab & more #44
Closed
+2,133
−1,265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n 'User Cancellation' First Install + some optimalisations
…o development-tostifrosti # Conflicts: # Renegade X Launcher/Tools/LaunchTools.cs
…ong.jsp) + sample servers fixed in design mode
…s utf-8 + settings window tooltip fix + username label clip fix + Join Server button hover effect added
The PR looks amazing, this might make it to the public. |
I'm slamming this through |
Except there's a merge conflict |
JAJames
approved these changes
Apr 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge conflict needs resolution before merge
# Conflicts: # Renegade X Launcher/ServerInfo.cs # Renegade X Launcher/Tools/LaunchTools.cs
@JAJames |
Closed due to inactivity & deprecation of the current launcher in favor of https://github.com/TotemArts/Launcher/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last months I've been (slowly) updating the Launcher to fix those nagging issues. This PR is a draft because I want to push more fixes in the future. There are a lot of changes, so this way you guys can already look into the recent commits and comment if you see any mistakes.
Changes:
UpdateAvailableWindow
&UsernameWindow
.New:
Removed:
Known issues:
This PR is related to an previous pushed PR that hasn’t been merged because of inactivity from my end. I will try to answer/clarify the questions/statements in that PR:
Of course this PR doesn't fix all the issues, but I'll try my best to work on those issues.
Hopefully you guys will find some time to look the changes ;)
Feel free to comment on any changes below!