refactor githubApiProxy method

Toyetop · Mar 31, 2015 · 0ff7791 · 0ff7791
1 parent 67228bf
commit 0ff7791
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/app/controllers/UsersController.php b/app/controllers/UsersController.php
@@ -92,16 +92,11 @@ public function githubApiProxy($username)
     {
         $cache_name = 'github_api_proxy_user_'.$username;
 
-        if (Cache::has($cache_name)) {
-            return Response::json(Cache::get($cache_name));
-        }
-
-        $result = (new GithubUserDataReader())->getDataFromUserName($username);
-
         //Cache 1 day
-        Cache::put($cache_name, $result, 1440);
-
-        return Response::json($result);
+        return Cache::remember($cache_name, 1440, function () use ($username) {
+            $result = (new GithubUserDataReader())->getDataFromUserName($username);
+            return Response::json($result);
+        });
     }
 
     public function githubCard()