Adds device type for iPhone X (matomo-org#5683)

Triadai · Nov 28, 2017 · a4841f5 · a4841f5
1 parent 0d7b4bc
commit a4841f5
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 17 deletions.
diff --git a/Tests/fixtures/phablet.yml b/Tests/fixtures/phablet.yml
@@ -1,4 +1,21 @@
 ---
+- 
+  user_agent: 'Mozilla/5.0 (iPhone; CPU iPhone OS 11_1 like Mac OS X) AppleWebKit/604.3.5 (KHTML, like Gecko) Mobile/15B86 [FBAN/FBIOS;FBAV/144.0.0.55.89;FBBV/74129168;FBDV/iPhone10,3;FBMD/iPhone;FBSN/iOS;FBSV/11.1;FBSS/3;FBCR/AT&T;FBID/phone;FBLC/en_US;FBOP/5;FBRV/74129168]'
+  os:
+    name: iOS
+    short_name: IOS
+    version: "11.1"
+    platform: ""
+  client:
+    type: mobile app
+    name: Facebook
+    version: "144.0.0.55.89"
+  device:
+    type: phablet
+    brand: AP
+    model: iPhone X
+  os_family: iOS
+  browser_family: Unknown
 - 
   user_agent: Mozilla/5.0 (Linux; Android 4.1.2; ME371MG Build/JZO54K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/33.0.1750.166 Safari/537.36
   os:

diff --git a/Tests/fixtures/unknown.yml b/Tests/fixtures/unknown.yml
@@ -3364,20 +3364,3 @@
     model: ""
   os_family: iOS
   browser_family: Unknown
-- 
-  user_agent: 'Mozilla/5.0 (iPhone; CPU iPhone OS 11_1 like Mac OS X) AppleWebKit/604.3.5 (KHTML, like Gecko) Mobile/15B86 [FBAN/FBIOS;FBAV/144.0.0.55.89;FBBV/74129168;FBDV/iPhone10,3;FBMD/iPhone;FBSN/iOS;FBSV/11.1;FBSS/3;FBCR/AT&T;FBID/phone;FBLC/en_US;FBOP/5;FBRV/74129168]'
-  os:
-    name: iOS
-    short_name: IOS
-    version: "11.1"
-    platform: ""
-  client:
-    type: mobile app
-    name: Facebook
-    version: "144.0.0.55.89"
-  device:
-    type: ""
-    brand: AP
-    model: iPhone X
-  os_family: iOS
-  browser_family: Unknown
diff --git a/regexes/device/mobiles.yml b/regexes/device/mobiles.yml
@@ -337,6 +337,7 @@ Apple:
       device: 'phablet'
     - regex: '(?:Apple-)?iPh(?:one)?10[C,][36]'
       model: 'iPhone X'
+      device: 'phablet'
 
     # specific tablet devices
     - regex: '(?:Apple-)?iPad1[C,]1'