Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS-8502 Add support for ED25519 keys, remove unused key checking code #101

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

travispaul
Copy link
Contributor

@travispaul travispaul commented Dec 4, 2023

Adds support for ED25519 keys and removes per-key-type related code that is no longer used.

This PR is related to TritonDataCenter/illumos-joyent/pull/462, there will be additional PRs (cloudapi, ufds, etc) to enable ED25519 support throughout the Triton stack.

See OS-8502 for testing notes.

Copy link
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one question, plus testing notes update requested per TritonDataCenter/illumos-joyent#462

@bahamat bahamat self-requested a review December 4, 2023 20:02
Copy link
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants