Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS-8595 ntp update for gcc 14 #132

Merged
merged 1 commit into from
Nov 14, 2024
Merged

OS-8595 ntp update for gcc 14 #132

merged 1 commit into from
Nov 14, 2024

Conversation

tsoome
Copy link
Contributor

@tsoome tsoome commented Nov 12, 2024

ntp has two problems:

  1. isc_ioctl() is expecting char * pointer
  2. configure pthread_detach() is expecting int, not pointer.

danmcd
danmcd approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For IA, check before/after dis(1) on a gcc10 build, these should be NOPs w.r.t. generated object code.

@tsoome
Copy link
Contributor Author

tsoome commented Nov 14, 2024

For IA, check before/after dis(1) on a gcc10 build, these should be NOPs w.r.t. generated object code.

Issue updated, no differences.

@tsoome tsoome merged commit cf5d86c into master Nov 14, 2024
2 checks passed
@tsoome tsoome deleted the OS-8595 branch November 14, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmcd danmcd danmcd approved these changes

Assignees
No one assigned
Labels
integration-approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsoome @danmcd