Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search, sort, and filters #43

Merged
merged 85 commits into from
Jun 14, 2024
Merged

Search, sort, and filters #43

merged 85 commits into from
Jun 14, 2024

Conversation

HarshGurnani
Copy link
Contributor

Tracking Info

Resolves #36

Changes

  • Search: Added search parameter to backend route for getting VSRs to match to name of veteran. Search bar on frontend listens to and responds to what user types in.
  • Sort: VSRs are sorted in specific order based on status and then date received (see specific status order in linked issue)
  • Filter: Users can filter by status, income level, and zip code. Added popup on frontend to filter by income level and zip code, and made status filter bar functional. Filtering parameters are passed into backend route for getting VSRs.

Testing

  • Ran frontend and backend on local and tested all features
  • While testing, make sure your local Mongo storage has some VSRs filled out

Confirmation of Change

Screenshot 2024-05-24 at 12 57 09 PM Screenshot 2024-05-24 at 12 57 20 PM Screenshot 2024-05-24 at 12 57 43 PM

TODO

  • Change popup to not be full screen

SamvritSrinath and others added 30 commits April 8, 2024 12:03
@SamvritSrinath
Writing Architecture for api/user
d23ac73
@sydneyzhang18
profile page frontend progress
760646a
@sydneyzhang18
admin info progress, will fix alignment issues
35dce85
@yotzkim
Initial branch
d231e02
@yotzkim
Initial branch
3ecaf9f
@holychickencow
added delete api route
cb4f383
@yotzkim
Made POST route to create furniture item and furniture item validator
9f2b367
@yotzkim
Merge commit
3c9b2f1
@yotzkim
Made POST route to create furniture item and furniture item validator
a55c805
@sydneyzhang18
more frontend, waiting on designer clarification to finalize
a025190
@sydneyzhang18
fixed frontend alignment issue
29a3df1
@yotzkim
Added PUT route for updating furniture items
e76c278
@yotzkim
Initial frontend and components structure
2442c8d
@yotzkim
Fixed Header bar
51eb55a
@yotzkim
Edit template component
b457985
@2s2e
Added backend for search function, haven't tested
baf5265
@2s2e
Removed other get route, and made search functionality work with vsr …
44cd0b5 
…route that was already there
@HarshGurnani
added sorting based on status and then date received
4e59205
@HarshGurnani
added searchability on frontend; bug: can only search by name, and ne…
c891e66 
…eds to be entire name for a result to hit
@holychickencow
added a button and have yet to add functionality to it
adffffe
@yotzkim
Merge branch 'main' into feat/daniel+yoto/furniture-edit-template
8b86ca1
@2s2e
temp commit
d709394
@2s2e
complete merge
d404f88
@2s2e
Revert "added searchability on frontend; bug: can only search by name…
365f6bf 
…, and needs to be entire name for a result to hit"

This reverts commit c891e66.
@2s2e
Revert "Revert "added searchability on frontend; bug: can only search…
8b39a02 
… by name, and needs to be entire name for a result to hit""

This reverts commit 365f6bf.
@2s2e
pasted harsh's original vsr.ts in, hopefully will solve merge issues
b167ec7
@2s2e
Added draft of backend code for testing
f540b60
@yotzkim
Added props for editing ability for EditTemplate and added comments f…
471cc83 
…or rendering series of EditTemplates
@2s2e
Added a popup, blank so far
2c66a2a
@HarshGurnani
modified FilterModal and zip code filtering
e09f0b5
benjaminJohnson2204
benjaminJohnson2204 approved these changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@benjaminJohnson2204 benjaminJohnson2204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work guys! I made a few small changes (mobile & tablet styling, changing filters popup to not be full screen, adding filtering capabilities for exporting VSRs). Also just a heads up, I'm going to use this PR to finish some other V2 features

@benjaminJohnson2204
Merge search/sort/filter branch
9c3f0fa
@benjaminJohnson2204
Remove unused files
7e94593
@benjaminJohnson2204
Save edits from VSR individual page directly rather than showing conf…
8131cc4 
…irmation popup
@benjaminJohnson2204
Fix linter issues
2cb2a86
@benjaminJohnson2204
Fix styling for edit furniture items feature
d73a39a
@benjaminJohnson2204
Require admin role for modifying furniture items
2f3c4a3
@benjaminJohnson2204
Merge branch 'feature/samvrit+sydney/Profile-Home-Page' into feature/…
ba9adbc 
…harsh-steven/search-sort-filter
@benjaminJohnson2204
Add mobile & tablet styles for profile page
9122f81
@benjaminJohnson2204
Redirect staff to profile page by default
7e8007b
@benjaminJohnson2204
Implement V2 nav bar
ca61cad
@benjaminJohnson2204
Implement create user feature
9375693
@benjaminJohnson2204
Delete user & change password features
129f479
@benjaminJohnson2204
Display confirmation dialog if user has unsaved changes
357d6bf
@benjaminJohnson2204
Notification emails to user & admin when password is changed
6c8e6d8
@benjaminJohnson2204
Edit confirmation email feature
7f22e2f
@benjaminJohnson2204
New build of backend
837fb44
@benjaminJohnson2204
Fix NextJS build errors
64483f5
@benjaminJohnson2204
Add type declaration files to dev dependencies
a370ed1
@benjaminJohnson2204
More type decl files
0f128d1
@benjaminJohnson2204
Debug firebase settings env var
84fff9b
@benjaminJohnson2204
Revert Firebase debugging
db3dc24
@benjaminJohnson2204
Fix styling issues Aska found with deployment
306581f
@benjaminJohnson2204
Make VSRs searching case insensitive
c37d1df
@benjaminJohnson2204
Rebuild backend
24c436b
@benjaminJohnson2204 benjaminJohnson2204 merged commit 768ddad into main Jun 14, 2024
4 checks passed
@benjaminJohnson2204 benjaminJohnson2204 deleted the feature/harsh-steven/search-sort-filter branch June 14, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminJohnson2204 benjaminJohnson2204 benjaminJohnson2204 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VSR Table Search, Sort, & Filter
7 participants
@HarshGurnani @benjaminJohnson2204 @SamvritSrinath @sydneyzhang18 @yotzkim @holychickencow @2s2e