opt_tools.py fixed to use cvxpy new imports #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess it also makes sense to include some tests against the latest release of that package to detect the issues in the CI as they happen. |
hoffmansc
requested changes
Dec 5, 2018
There was a problem hiding this comment.
It looks like the syntax for Variables has changed slightly as well. The shape input must be a tuple now instead of separate arguments so lines 293-95 need to be fixed as well.
Also, if you could change the requirements.txt file to reflect the backwards-incompatible version requirement, that should fix the Travis build. You can just change line 14 to cvxpy>=1.0.
Thanks for your contribution!
* `Variable` now takes shape as a tuple only * requirements updated to reflect backwards-incompatible switch to cvxpy 1.0+
hoffmansc
force-pushed
the
maria-fixbug
branch
2 times, most recently
from
dfcd6ce to
4028285
Compare
hoffmansc
force-pushed
the
maria-fixbug
branch
from
4028285 to
c7ca1a6
Compare
hoffmansc
approved these changes
Dec 11, 2018
Illia-Kryvoviaz
pushed a commit
to Illia-Kryvoviaz/AIF360
that referenced
this pull request
Jun 7, 2023
* initial commit * additional compat fixes for cvxpy 1.0+ * `Variable` now takes shape as a tuple only * requirements updated to reflect backwards-incompatible switch to cvxpy 1.0+ * avoid overriding built-in sum
Illia-Kryvoviaz
pushed a commit
to Illia-Kryvoviaz/AIF360
that referenced
this pull request
Jun 7, 2023
* initial commit * additional compat fixes for cvxpy 1.0+ * `Variable` now takes shape as a tuple only * requirements updated to reflect backwards-incompatible switch to cvxpy 1.0+ * avoid overriding built-in sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the opt_tools.py file in order to use the updated cvxpy functions.