Skip to content

Commit

Permalink
Bundle vcruntime140_1.dll in NPMs (facebook#269)
Browse files Browse the repository at this point in the history
Summary: Pull Request resolved: facebook#269

Test Plan: Submitted as a GitHub PR. CircleCI artifacts shows the file is included.

Reviewed By: tmikov

Differential Revision: D21939479

Pulled By: willholen

fbshipit-source-id: 883168320b02119e1d99892f99d7942e89cf19dd
  • Loading branch information
willholen authored and facebook-github-bot committed Jun 9, 2020
1 parent 9c952b8 commit 7bee987
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,7 @@ jobs:
# Include MSVC++ 2015 redistributables
Copy-Item -Path "c:\windows\system32\msvcp140.dll" -Destination "deps"
Copy-Item -Path "c:\windows\system32\vcruntime140.dll" -Destination "deps"
Copy-Item -Path "c:\windows\system32\vcruntime140_1.dll" -Destination "deps"
- run:
name: Build Hermes for Windows
Expand Down
1 change: 1 addition & 0 deletions npm/hermes-engine-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"win64-bin/icuuc64.dll",
"win64-bin/msvcp140.dll",
"win64-bin/vcruntime140.dll",
"win64-bin/vcruntime140_1.dll",
"win64-bin/hbcdump.exe",
"win64-bin/hdb.exe",
"win64-bin/hermes.exe",
Expand Down
3 changes: 2 additions & 1 deletion npm/hermes-engine/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"osx-bin/hermesc",
"win64-bin/hermesc.exe",
"win64-bin/msvcp140.dll",
"win64-bin/vcruntime140.dll"
"win64-bin/vcruntime140.dll",
"win64-bin/vcruntime140_1.dll"
]
}

0 comments on commit 7bee987

Please sign in to comment.