Skip to content

Commit

Permalink
SAK-31820 Fix roster display of roster group (sakaiproject#3466)
Browse files Browse the repository at this point in the history
Roster groups where being shown regardless of what the permission
was. This was fixed.
  • Loading branch information
master-bob authored and ottenhoff committed Nov 29, 2016
1 parent bf00bfe commit fb4e4bc
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion roster2/src/handlebars/members.handlebars
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
{{/if}}
{{/if}}
{{#if hasGroups}}
{{#if ../viewGroup}}
<div class="roster-table-row">
<div class="roster-table-cell">{{translate 'groups'}}</div>
<div class="roster-table-cell">
Expand Down
2 changes: 2 additions & 0 deletions roster2/src/handlebars/overview.handlebars
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

<div class="row">
<div class="form-group col-sm-6">
{{#if viewGroup}}
<label for="roster-groups-selector-top" class="form-control-label col-sm-3">{{translate 'groups'}}</label>
<div class="col-sm-4">
<select id="roster-groups-selector-top">
Expand All @@ -13,6 +14,7 @@
{{/each}}
</select>
</div>
{{/if}}
</div>
<div class="form-group col-sm-6">
<label for="roster-roles-selector" class="form-control-label col-sm-2">{{translate 'roles_label'}}</label>
Expand Down
1 change: 1 addition & 0 deletions roster2/src/webapp/js/roster.js
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,7 @@
'viewEmail': roster.viewEmail,
'viewUserDisplayId': roster.viewUserDisplayId,
'viewProfile': roster.currentUserPermissions.viewProfile,
'viewGroup' : roster.currentUserPermissions.viewGroup,
'viewPicture': true,
'currentUserId': roster.userId,
'viewOfficialPhoto': roster.currentUserPermissions.viewOfficialPhoto,
Expand Down

0 comments on commit fb4e4bc

Please sign in to comment.