Bugfix/939 clob getall office filter #1024
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 12, 2025 15:59
Removed test method that had identical implemention.
…in current office and then all the other offices. Using vOffice and vClob to match naming conventions. Adding orderBy to the getClobsLike results for consistency.
rma-rripken
requested review from
MikeNeilson and
adamkorynta
and removed request for
MikeNeilson
MikeNeilson
reviewed
Feb 14, 2025
| } else { | ||
| clobConsumer.accept(null); | ||
| } | ||
| clobConsumer.accept(clob); |
There was a problem hiding this comment.
are we sure null here isn't valid?
There was a problem hiding this comment.
I think it is valid. Its just that when clob == null the variable clob already has null in it so clobConsumer.accept(clob) is the right line in either case. I didn't spot this myself, the IDE suggested it. More of a - 'Huh - its right. ok.'
There was a problem hiding this comment.
oh right we're just passing null anyways.
MikeNeilson
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm redoing pr #937 to address #939.
develop had moved significantly since #937 had been started that it seemed cleaner to just grab the handful of changes.