Make <project>'s default attribute required to stop the sky from fall…

…ing.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@273163 13f79535-47bb-0310-9956-ffa450edef68

docs/manual/using.html

@@ -30,7 +30,7 @@ <h3><a name="projects">Projects</a></h3>
   <tr>
     <td valign="top">default</td>
     <td valign="top">the default target to use when no target is supplied.</td>
-    <td align="center" valign="top">No.  No target will be run if omitted.</td>
+    <td align="center" valign="top"><!-- No.  No target will be run if omitted.--> Yes.</td>
   </tr>
   <tr>
     <td valign="top">basedir</td>

src/etc/testcases/core/topleveltasks/notarget.xml

@@ -1,3 +1,4 @@
-<project>
+<project default="foo">
   <echo message="Called" />
+  <target name="foo" />
 </project>

src/etc/testcases/core/topleveltasks/toplevelant.xml

@@ -1,3 +1,4 @@
-<project basedir=".">
+<project basedir="." default="foo">
   <ant antfile="notarget.xml" />
+  <target name="foo" />
 </project>

src/etc/testcases/taskdefs/java.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 
-<project name="java-test" basedir="." default="">
+<project name="java-test" basedir="." default="foo">
 
   <property name="app" 
     value="org.apache.tools.ant.taskdefs.JavaTest$$EntryPoint" />
@@ -89,4 +89,5 @@
     </java>
   </target>
 
+  <target name="foo" />
 </project>

src/main/org/apache/tools/ant/helper/ProjectHelperImpl.java

@@ -454,6 +454,8 @@ public void init(String tag, AttributeList attrs) throws SAXParseException {
 
             if (def != null && !def.equals("")) {
                 helperImpl.project.setDefaultTarget(def);
+            } else {
+                throw new BuildException("The default attribute is required");
             }
 
             if (name != null) {