Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDA in WDK: Integrate EDA scatterplot in WDK record page #1325

Merged
merged 48 commits into from
Feb 24, 2025

Conversation

dmfalke
Copy link
Member

@dmfalke dmfalke commented Feb 14, 2025

fixes #1312

This PR builds off of #1314. It integrates an EDA scatterplot into a WDK gene page, for crispr phenotype data.


TODOs

  • Prototype use of scatterplot on gene page
  • Refactor ExpressionGraph component to use new record table that will include plot configs per dataset (JB is working on this)

Testing

I am testing it with a local genomics-site dev server, using my dev site, which is configured to use toxo068n, since phenotype data isn't showing up on toxo-inc.

In packages/sites/genomics-site/.env:

BASE_PROXY_URL=https://dfalke-b.toxodb.org
LEGACY_WEB_APP_URL=${BASE_PROXY_URL}/toxo
PROJECT_ID=ToxoDB

Run yarn nx start @veupathdb/genomics-site and navigate to http://localhost:8080/a/app/record/gene/TGGT1_261490#category:phenomics.

dmfalke and others added 30 commits January 28, 2025 14:37
* fix for thumnails not rendering

* replace mutating state with better check of filters
* added plot annotations functionality

* improve scatter annotation story

* added histogram annotation story

* introduce VEuPathDBAnnotation type

* fix annotation types in histogram
studyId,
filters: [],
config: {
outputEntityId: xAxisVariable.entityId,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asizemore I'm linking this comment to this pr.

To address your question, I wonder if this should be a part of the plot configuration that we will be getting from the record table. Might be a question for @jbrestel

@dmfalke dmfalke changed the title Eda in wdk: record page EDA in WDK: Integrate EDA scatterplot in WDK record page Feb 17, 2025
@dmfalke dmfalke merged commit cdf3a33 into main Feb 24, 2025
1 check passed
@dmfalke dmfalke deleted the eda-in-wdk/record-page branch February 24, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EDA - Embeddable visualizations
3 participants