-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDA in WDK: Integrate EDA scatterplot in WDK record page #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix for thumnails not rendering * replace mutating state with better check of filters
* added plot annotations functionality * improve scatter annotation story * added histogram annotation story * introduce VEuPathDBAnnotation type * fix annotation types in histogram
dmfalke
commented
Feb 14, 2025
studyId, | ||
filters: [], | ||
config: { | ||
outputEntityId: xAxisVariable.entityId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asizemore I'm linking this comment to this pr.
To address your question, I wonder if this should be a part of the plot configuration that we will be getting from the record table. Might be a question for @jbrestel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1312
This PR builds off of #1314. It integrates an EDA scatterplot into a WDK gene page, for crispr phenotype data.
TODOs
Testing
I am testing it with a local genomics-site dev server, using my dev site, which is configured to use toxo068n, since phenotype data isn't showing up on toxo-inc.
In packages/sites/genomics-site/.env:
Run
yarn nx start @veupathdb/genomics-site
and navigate to http://localhost:8080/a/app/record/gene/TGGT1_261490#category:phenomics.