ext4: remove useless marking of superblock dirty

Commit a037515 properly notes that superblock doesn't need to be marked as dirty when only number of free inodes / blocks / number of directories changes since that is recomputed on each mount anyway. However that comment leaves some unnecessary markings as dirty in place. Remove these. Artem: tested using xfstests for both journalled and non-journalled ext4. Signed-off-by: Jan Kara <[email protected]> Signed-off-by: Artem Bityutskiy <[email protected]> Signed-off-by: "Theodore Ts'o" <[email protected]> Tested-by: Artem Bityutskiy <[email protected]>
VadimAlexeev · Jul 23, 2012 · 97a7406 · 97a7406
1 parent 2547060
commit 97a7406
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 4 deletions.
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
@@ -315,7 +315,6 @@ void ext4_free_inode(handle_t *handle, struct inode *inode)
 		err = ext4_handle_dirty_metadata(handle, NULL, bitmap_bh);
 		if (!fatal)
 			fatal = err;
-		ext4_mark_super_dirty(sb);
 	} else
 		ext4_error(sb, "bit already cleared for inode %lu", ino);
 
@@ -830,7 +829,6 @@ struct inode *ext4_new_inode(handle_t *handle, struct inode *dir, umode_t mode,
 	percpu_counter_dec(&sbi->s_freeinodes_counter);
 	if (S_ISDIR(mode))
 		percpu_counter_inc(&sbi->s_dirs_counter);
-	ext4_mark_super_dirty(sb);
 
 	if (sbi->s_log_groups_per_flex) {
 		flex_group = ext4_flex_group(sbi, group);

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
@@ -2831,7 +2831,6 @@ ext4_mb_mark_diskspace_used(struct ext4_allocation_context *ac,
 	err = ext4_handle_dirty_metadata(handle, NULL, gdp_bh);
 
 out_err:
-	ext4_mark_super_dirty(sb);
 	brelse(bitmap_bh);
 	return err;
 }
@@ -4700,7 +4699,6 @@ void ext4_free_blocks(handle_t *handle, struct inode *inode,
 		put_bh(bitmap_bh);
 		goto do_more;
 	}
-	ext4_mark_super_dirty(sb);
 error_return:
 	brelse(bitmap_bh);
 	ext4_std_error(sb, err);