Some simple refactoring #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, a few steps toward simplifying the import structure of the various modules, avoiding unnecessary dependencies, parsimony in suppressing warning messages, et cetera.
1. Restate mat_vec_mul_mixed_error' in a more mathcomp-idiomatic way as mat_vec_mul_mixed_error''. 2. Notice (in theorem forward_error'') that the exact same proof script can make use of this new formulation. 3. Avoid the use of Coqlib.
- Use only the newer (mathcomp-idiomatic) statement of mat_vec_mul_mixed_error lemma - Reorder matrix_index arguments so default (zero) comes first - Eliminate getm, just use matrix_index instead. - Other small cleanups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, a few steps toward simplifying the import structure of the various modules, avoiding unnecessary dependencies, parsimony in suppressing warning messages, et cetera.