Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output dir #5

Merged
merged 5 commits into from
Jan 6, 2022
Merged

Output dir #5

merged 5 commits into from
Jan 6, 2022

Conversation

capnramses
Copy link
Contributor

@capnramses capnramses commented Jan 5, 2022 •
edited
Loading

Reason for PR:

  • currently all files are dumped into working directory, which can be annoying to separate out if there are a lot of files, or you wish to process several different volograms

Changes in PR

  • --output_dir some_dir flag added to command line parameters
  • it should work with any of the following combinations of slashes at the end: --output_dir some_dir my_dir/ , --output_dir some_dir my_dir\\ , --output_dir some_dir my_dir\ , --output_dir some_dir my_dir
  • if directory does not already exist it attempts to create it using POISX routines, or win32 routines if _WIN32 or _WIN64 are defined.
  • updated --help and Readme.md.
  • bumped version number

Testing summary

  • Tested on Windows 7 with a MinGW build
  • Tested in a WSSL Ubuntu terminal on Windows

Risks and coverage weaknesses

  • * Testing on macOS.
  • * Testing Visual Studio build.
  • * Testing on any other Linux configurations or native Ubuntu.

@capnramses capnramses linked an issue Jan 5, 2022 that may be closed by this pull request
add an option to specify (or create) an output directory #1
Closed
@capnramses
Copy link
Contributor Author

visual studio build works fine

@capnramses
Copy link
Contributor Author

ubuntu native os works fine

valeria-volu
valeria-volu approved these changes Jan 6, 2022
View reviewed changes
Copy link

@valeria-volu valeria-volu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows 10 - works as expected

@capnramses capnramses merged commit e0fb5d7 into main Jan 6, 2022
@capnramses capnramses deleted the output_dir branch July 20, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valeria-volu valeria-volu valeria-volu approved these changes

@rafapages rafapages Awaiting requested review from rafapages

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add an option to specify (or create) an output directory
2 participants
@capnramses @valeria-volu