CVE-2013-7348 and CVE-2022-3105 #204

as9215 · 2023-11-06T18:52:43Z

No description provided.

ahetrick12

Overall nice job, just a few things missing really

ahetrick12 · 2023-11-07T20:44:17Z

CVE-2013-7348.yml

+  note:
+  answer:


Even if it's not clear if this vulnerability is autodiscoverable, I'd still take your best shot at answering this

ahetrick12 · 2023-11-07T20:46:01Z

CVE-2013-7348.yml

+    adding or improving an automated test to ensure this doesn't happen again.
+  fix_answer:
+  code_answer:
+reported_date:


Reported date can be the same as announced or published date if there's no info about it, but I see on the openwall page linked to the NVD page for this CVE that the CVE was created on March 31st 2014, so that might be something to go off of

ahetrick12 · 2023-11-07T20:46:24Z

CVE-2013-7348.yml

+    what your answer was.
+  any_stacktraces:
+  stacktrace_with_fix:
+description:


Definitely try to add a short and easy-to-read description of the vulnerability!

I agree. I think most importantly you need a straightforward what happened and what vulnerabilities resulted from it.

ahetrick12 · 2023-11-07T20:46:59Z

CVE-2013-7348.yml

+
+    Write a thoughtful entry here that people in the software engineering
+    industry would find interesting.
+nickname:


I think this goes hand in hand with the description, try to come up with something short and clever

ahetrick12 · 2023-11-07T20:48:18Z

CVE-2013-7348.yml

+  serial_killer:
+    note:
+    applies: False
+  complex_inputs:
+    note:
+    applies: True
+  distrust_input:
+    note:
+    applies: True
+  least_privilege:
+    note:
+    applies: False
+  native_wrappers:
+    note:
+    applies: False
+  defense_in_depth:
+    note:
+    applies: False
+  secure_by_default:
+    note:
+    applies: False
+  environment_variables:
+    note:
+    applies: False
+  security_by_obscurity:
+    note:
+    applies: False
+  frameworks_are_optional:
+    note:
+    applies: False


I think at least one of these should probably apply, like e.g. maybe defense in depth?

ahetrick12 · 2023-11-07T20:49:33Z

CVE-2013-7348.yml

+    Write a note about how you came to the conclusions you did, regardless of
+    what your answer was.
+vccs:
+  - note: Discovered automatically by archeogit.


Maybe add a short explanation of what this commit is, as well as the others in the "fixes" section that just have "manually confirmed" in the note

ahetrick12 · 2023-11-07T20:50:04Z

CVE-2022-3105.yml

+vccs:
+  - note: Discovered automatically by archeogit.
+    commit: 6884c6c4bd09fb35b79a3967d15821cdfcbe77a3
+fixes:
+  - note:
+    commit:
+  - note:
+    commit:
+  - note: Manually confirmed
+    commit: 7694a7de22c53a312ea98960fcafc6ec62046531


Can add some short descriptions about the commits and remove anything blank

ahetrick12 · 2023-11-07T20:50:50Z

CVE-2022-3105.yml

+lessons:
+  yagni:
+    note:
+    applies: [distrust_input, complex_input]


I think yagni is a lesson itself, you'd probably just put "false" here if it doesn't apply

ahetrick12 · 2023-11-07T20:51:34Z

CVE-2022-3105.yml

+    what your answer was.
+  any_stacktraces:
+  stacktrace_with_fix:
+description:


Make sure to add a description of the vulnerability here, like I mentioned in your other CVE

ska4865 · 2023-11-08T17:28:14Z

CVE-2013-7348.yml

+    what your answer was.
+  any_stacktraces:
+  stacktrace_with_fix:
+description:


I agree. I think most importantly you need a straightforward what happened and what vulnerabilities resulted from it.

ska4865 · 2023-11-08T17:29:23Z

CVE-2013-7348.yml

+  fix_answer:
+  code_answer:
+reported_date:
+specification:


May have just forgot this one. The reasoning doesn't have to be too long but I do think you should have it

ska4865 · 2023-11-08T17:35:10Z

CVE-2022-3105.yml

+CWE:
+  - 476
+ipc:
+  note: This is primarily used for communication between user-space applications and kernel-space InfiniBand (IB) and Remote Direct Memory Access (RDMA) drivers. It doesn't directly deal with inter-process communication (IPC) mechanisms such as OS signals, pipes, stdin/stdout, message passing, clipboard, or file-based IPC.


I think you can focus on what the vulnerability does and you don't need to reiterate IPC because we should all know what it is at this point

ska4865 · 2023-11-08T17:35:56Z

CVE-2022-3105.yml

+CVSS: CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:H
+bugs: [2153067]
+i18n:
+  note: It is unlikely that the vulnerabilities or issues related to this code have a direct impact on internationalization (i18n) features. Internationalization features in software are generally concerned with providing support for different languages, character encodings, locales, and user interface translations, among other aspects. 


Once again I don't think you need to define i18n in your answer.

ska4865 · 2023-11-08T17:38:09Z

CVE-2022-3105.yml

+    If there is no evidence as to how this vulnerability was found, then please
+    explain where you looked.
+  automated: False
+  developer: True


I believe you need to put the developers name instead of true here

ska4865 · 2023-11-08T17:39:05Z

CVE-2022-3105.yml

+  automated: False
+  developer: True
+discussion:
+  note: I was not able to find any disagreements


You marked discussion and security as true though?

ska4865 · 2023-11-08T17:40:18Z

CVE-2022-3105.yml

+    comment you want to make.
+  any_discussion: True
+  discussed_as_security: True
+stacktrace:


I think you just forgot this one. Even if you didn't find a stacktrace you should still put false down

ska4865 · 2023-11-08T17:41:53Z

CVE-2022-3105.yml

+  stacktrace_with_fix:
+description:
+unit_tested:
+  fix:


Since you found a unit test was it good was it bad? Do you know who made it? Was it made before or after the cause of the vulnerability but before the fix? You don't have to answer all my questions exactly but I think they'd be good to think about.

ska4865 · 2023-11-08T17:43:50Z

CVE-2022-3105.yml

+    Write a note about how you came to the conclusions you did, regardless of
+    what your answer was.
+autodiscoverable:
+  note: An empty dataset would trigger this vulnerability


Would a automated tool be able to interpret the result it gets from this?

LandonHeatly · 2023-11-09T17:25:46Z

CVE-2022-3105.yml

-      Taken from NVD references list with Git commit. If you are
-
-      curating, please fact-check that this commit fixes the vulnerability and replace this comment with 'Manually confirmed'
+  - note: Manually confirmed


I would recommend leaving a short note describing what this commit does, just a few words for the reader to know how it fixes the vulnerability.

LandonHeatly · 2023-11-09T17:36:06Z

CVE-2022-3105.yml

@@ -361,8 +357,8 @@ interesting_commits:
      * Other commits that fixed a similar issue as this vulnerability


I'd recommend adding a commit or two in the interesting commits section or at least mentioning why there weren't any (they were trivial, there weren't any at all, etc.)

LandonHeatly · 2023-11-09T17:36:33Z

CVE-2022-3105.yml

Overall, I agree with most of what the other commenters have added here. The only place I'd disagree is that I like how you break down some concepts, as these notes are meant for someone with less programming experience than us. I'd make sure you add the description of the vulnerability as I don't actually know what it is. I know it deals with communication and drivers but that's about it. I'd recommend re-forking as the format of this file is different from the main repository and you're missing some key points.

LandonHeatly · 2023-11-09T17:51:28Z

CVE-2013-7348.yml

Overall, I agree with most of what the other commenters have added here. I'd make sure you add the description of the vulnerability as I don't actually know what it is. I'd recommend re-forking as the format of this file is different from the main repository and you're missing some key points. The answers seem to be before the questions and out of order.

LandonHeatly · 2023-11-09T18:02:40Z

CVE-2013-7348.yml

  complex_inputs:
    note:
-    applies:
+    applies: True


Make sure to mention why this applies.
Same with distrust input.

LandonHeatly · 2023-11-09T18:06:12Z

CVE-2013-7348.yml

 discussion:
-  note:
+  note: https://mirrors.edge.kernel.org/pub/linux/kernel/v3.x/ChangeLog-3.0.10


A link is good, but I'd recommend also adding a short description.

as9215 and others added 4 commits November 1, 2023 21:40

added CVE's

27f7e34

trying again

d627464

CVE-2013-7348.yml

96e01fe

CVE-2022-3105.yml

dd84faf

andymeneely added the cohort H label Nov 7, 2023

ahetrick12 reviewed Nov 7, 2023

View reviewed changes

ska4865 reviewed Nov 8, 2023

View reviewed changes

LandonHeatly reviewed Nov 9, 2023

View reviewed changes

CVE-2013-7348.yml

complex_inputs:

note:

applies:

applies: True

Copy link

LandonHeatly Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to mention why this applies.
Same with distrust input.

LandonHeatly reviewed Nov 9, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CVE-2013-7348 and CVE-2022-3105 #204

CVE-2013-7348 and CVE-2022-3105 #204

as9215 commented Nov 6, 2023

ahetrick12 left a comment

ahetrick12 Nov 7, 2023

ahetrick12 Nov 7, 2023

ahetrick12 Nov 7, 2023

ska4865 Nov 8, 2023

ahetrick12 Nov 7, 2023

ahetrick12 Nov 7, 2023

ahetrick12 Nov 7, 2023

ahetrick12 Nov 7, 2023

ahetrick12 Nov 7, 2023

ahetrick12 Nov 7, 2023

ska4865 Nov 8, 2023

ska4865 Nov 8, 2023

ska4865 Nov 8, 2023

ska4865 Nov 8, 2023

ska4865 Nov 8, 2023

ska4865 Nov 8, 2023

ska4865 Nov 8, 2023

ska4865 Nov 8, 2023

ska4865 Nov 8, 2023

LandonHeatly Nov 9, 2023

LandonHeatly Nov 9, 2023

LandonHeatly Nov 9, 2023

LandonHeatly Nov 9, 2023

LandonHeatly Nov 9, 2023

LandonHeatly Nov 9, 2023

		@@ -361,8 +357,8 @@ interesting_commits:
		* Other commits that fixed a similar issue as this vulnerability

CVE-2013-7348 and CVE-2022-3105 #204

Are you sure you want to change the base?

CVE-2013-7348 and CVE-2022-3105 #204

Conversation

as9215 commented Nov 6, 2023

ahetrick12 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment