CVE-2018-8087 and CVE-2016-4998 #218

lollygagger · 2023-11-08T22:59:53Z

Completed yaml files for CVE-2018-8087 and CVE-2016-4998

nolan-white · 2023-11-12T01:13:46Z

cves/kernel/CVE-2016-4998.yml

@@ -55,7 +55,7 @@ description_instructions: |

  Your target audience is people just like you before you took any course in
  security
-description:
+description: underprivileged users were able to call a command normally limited to root. This allows for underprivileged user root access.


First sentence should be capitalized. Also, the official CVE description contains more information about the vulnerability than this description does. As a reader, I'm left wondering "What was the command? How were underprivileged users able to access it? What impacts could exploiting this vulnerability have?" I would suggest adding this context to your description.

nolan-white · 2023-11-12T01:15:31Z

cves/kernel/CVE-2016-4998.yml

-  automated:
-  contest:
-  developer:
+  answer: This vulnerability was found by using a fuzzer tool on the linux kernel


Missing period at end of sentence.

nolan-white · 2023-11-12T01:16:18Z

cves/kernel/CVE-2016-4998.yml

@@ -167,8 +153,8 @@ autodiscoverable:

    The answer field should be boolean. In answer_note, please explain
    why you come to that conclusion.
-  note:
-  answer:
+  note: This was discovered by an automated fuzzer


Missing period at end of sentence.

nolan-white · 2023-11-12T01:16:57Z

cves/kernel/CVE-2016-4998.yml

@@ -184,8 +170,8 @@ specification:

    The answer field should be boolean. In answer_note, please explain
    why you come to that conclusion.
-  note:
-  answer:
+  note: there was no violation of any standard as this was a memory spacing issue.


First word in sentence should be capitalized.

nolan-white · 2023-11-12T01:17:48Z

cves/kernel/CVE-2016-4998.yml

-  note:
+i18n:
+  answer: false
+  note: This did not have to do with i18n as it was an issue with having access to too much memory


Missing period at end of sentence.

nolan-white · 2023-11-12T01:18:17Z

cves/kernel/CVE-2016-4998.yml

-  answer:
-  note:
+  answer: false
+  note: This did not violate a sandboxing feature that the system provides


Missing period at end of sentence.

nolan-white · 2023-11-12T01:19:50Z

cves/kernel/CVE-2016-4998.yml

-  answer:
-  note:
+  answer: false
+  note: no IPC was occuring.


First word in sentence should be capitalized.

nolan-white · 2023-11-12T01:24:44Z

cves/kernel/CVE-2016-4998.yml

-  note:
+  discussed_as_security: false
+  any_discussion: false
+  note: there was minimal discussion as this was discovered then immediately fixed


Missing period and first word in sentence should be capitalized.

nolan-white · 2023-11-12T01:24:48Z

cves/kernel/CVE-2016-4998.yml

-  answer:
-  note:
+  answer: false
+  note: the only discussion present was during fuzzing the kernel.


First word in sentence should be capitalized. Also this information is not correct as the commit that fixed the issue was signed off on by Florian Westphal and Pablo Neira Ayuso.

nolan-white · 2023-11-12T01:25:24Z

cves/kernel/CVE-2016-4998.yml

-  note:
+  any_stacktraces: false
+  stacktrace_with_fix: false
+  note: no stacktrace as this was discovered by fuzzing and posted on a forum.


First word in sentence should be capitalized.

nolan-white · 2023-11-12T01:27:21Z

cves/kernel/CVE-2016-4998.yml

-  answer:
-  note:
+  answer: true
+  note: there was a missing check to see that the data being accessed was within the active blob


Missing period and first word in sentence should be capitalized. Also "the data being accessed was within the active blob" feels a little too jargony for readers without further explanation.

nolan-white · 2023-11-12T01:27:39Z

cves/kernel/CVE-2016-4998.yml

@@ -369,7 +322,7 @@ order_of_operations:
    Answer must be true or false.
    Write a note about how you came to the conclusions you did, regardless of
    what your answer was.
-  answer:
+  answer: false
  note:


Note missing.

nolan-white · 2023-11-12T01:29:35Z

cves/kernel/CVE-2016-4998.yml

 nickname_instructions: |
  A catchy name for this vulnerability that would draw attention it.
  If the report mentions a nickname, use that.
  Must be under 30 characters. Optional.
-nickname:
-CVSS:
+nickname: out of blob memory access


Looking at the other vulnerabilities on the VHP website, this should be capitalized like a title for consistency.

nolan-white · 2023-11-12T01:29:51Z

cves/kernel/CVE-2016-4998.yml

@@ -467,11 +420,10 @@ CWE_instructions: |
 CWE:
 - 119
 CWE_note: |
-  CWE as registered in the NVD. If you are curating, check that this
-  is correct and replace this comment with "Manually confirmed".
+  manually confirmed


First word should be capitalized.

nolan-white · 2023-11-12T01:30:05Z

cves/kernel/CVE-2016-4998.yml

@@ -448,7 +401,7 @@ mistakes:

    Write a thoughtful entry here that people in the software engineering
    industry would find interesting.
-  answer:
+  answer: There was a forgotten check that made a small error. This mistake was most likely a lapse during development


Last sentence missing period. Also what was the lapse in judgement? The reader may not look at the source code, so I would suggest including a high-level description of the check that was forgotten.

nolan-white · 2023-11-12T01:42:33Z

cves/kernel/CVE-2016-4998.yml

lollygagger added 7 commits November 8, 2023 17:58

CVE-2018-8087 and CVE-2016-4998

0c0dae5

completed CVE-2018-8087

1b13733

removed curation_level to check if cve-2018-8087 passed yaml checks

fc9c592

resolving yaml errors with first vulnerabilitiy

fe220ce

finished resolving errors with cve-2018-8087

0f1fe75

2016-4998

038a2b6

changes to satisfy yaml formatting:

ecb8a28

andymeneely added the cohort N label Nov 10, 2023

nolan-white reviewed Nov 12, 2023

View reviewed changes

cves/kernel/CVE-2016-4998.yml

Copy link

nolan-white Nov 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 upvotes

Updates from feedback on PR

8e09f60

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CVE-2018-8087 and CVE-2016-4998 #218

CVE-2018-8087 and CVE-2016-4998 #218

lollygagger commented Nov 8, 2023

nolan-white Nov 12, 2023 •

edited

Loading

nolan-white Nov 12, 2023

nolan-white Nov 12, 2023

nolan-white Nov 12, 2023 •

edited

Loading

nolan-white Nov 12, 2023

nolan-white Nov 12, 2023

nolan-white Nov 12, 2023

nolan-white Nov 12, 2023

nolan-white Nov 12, 2023 •

edited

Loading

nolan-white Nov 12, 2023

nolan-white Nov 12, 2023

nolan-white Nov 12, 2023

nolan-white Nov 12, 2023

nolan-white Nov 12, 2023

nolan-white Nov 12, 2023 •

edited

Loading

nolan-white Nov 12, 2023

CVE-2018-8087 and CVE-2016-4998 #218

Are you sure you want to change the base?

CVE-2018-8087 and CVE-2016-4998 #218

Conversation

lollygagger commented Nov 8, 2023

nolan-white Nov 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nolan-white Nov 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nolan-white Nov 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nolan-white Nov 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nolan-white Nov 12, 2023 •

edited

Loading

nolan-white Nov 12, 2023 •

edited

Loading

nolan-white Nov 12, 2023 •

edited

Loading

nolan-white Nov 12, 2023 •

edited

Loading