Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2016-9754 and CVE-2022-0516 #225

Open
wants to merge 20 commits into
base: dev
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix autodiscoverable answer
  • Loading branch information
evstod committed Nov 11, 2023
commit 34ee0ca496eec365a3d679547e86e03cd5e7821f
4 changes: 2 additions & 2 deletions cves/kernel/CVE-2016-9754.yml
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,8 @@ autodiscoverable:

The answer field should be boolean. In answer_note, please explain
why you come to that conclusion.
note: true
answer: 'Buffer overflows can be found by automated tools.'
note: 'Buffer overflows can be found by automated tools.'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a buffer overflow, but rather an integer overflow - https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=59643d1535eb220668692a5359de22545af579f6

This, under certain situations, can still be found by certain automated testers such as syzkaller

Copy link
Author

@evstod evstod Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. The integer in question controls the buffer size for the ring buffer, which caused me to misidentify the issue. Fixed the note.

answer: true
specification:
instructions: |
Is there mention of a violation of a specification? For example, the POSIX
Expand Down