Dev #158
Merged
Dev #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change weights generation to increase memeff
|
Is our envisioned v1.0 affected by this issue? Are we sure that MODAPE produces the exact same results with this mem-optimizing tweak to the implementation? |
|
@interob yes, hence the PR against v1.0rc. I've did a quick test which yielded the same results, plus all tests are passing. If you look at the code, it's really just a minor change. But not allocating the full weights array in |
collect: suppress debug message on interleaving when interleave = False
fix copy/paste error in line 85
implements checks for tile/date consistency
|
Ready for merge @interob could you review the changes and see if they are OK for you? This includes now some fixes, the date/tile check and fixed/improved testing |
update docs (address #140 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds memfix - all checks passed