Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec] Fix navigation from the default constructor not installing a fenced frame config. #183

Merged
merged 11 commits into from
Oct 5, 2024
Merged

[Spec] Fix navigation from the default constructor not installing a fenced frame config. #183

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7d4c90d
Fix default constructor not instantiating fenced frame config
blu25 Aug 19, 2024
bb4343d
Update spec.bs
blu25 Aug 27, 2024
dc2158d
Merge branch 'master' into liam-default-config-navigate
blu25 Aug 27, 2024
449a598
cleanup
blu25 Aug 27, 2024
832bd5c
fix outdated naming
blu25 Aug 27, 2024
6f0eedc
address review comments
blu25 Sep 20, 2024
a2d6656
modify check to check ancestor navigables
blu25 Sep 30, 2024
076149e
address comments and add unfenced ancestor patch
blu25 Oct 3, 2024
a04d199
revert and add issue link
blu25 Oct 4, 2024
9205b85
remove inclusive ancestor navigables patch
blu25 Oct 4, 2024
3675ec4
Issue wording
domfarolino Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix outdated naming
  • Loading branch information
@blu25
blu25 committed Aug 27, 2024
commit 832bd5c2cc174e3ebed4b6aed536a7049fdc4420
6 changes: 3 additions & 3 deletions spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2903,13 +2903,13 @@ CORP violation report=] algorithm, as leaving it unfenced may cause a privacy le
: [=mapped url/visibility=]
:: [=visibility/transparent=]

: [=fenced frame config/effective sandbox flags=]
: [=fenced frame config/effective sandboxing flags=]
:: a [=struct=] with the following [=struct/items=]:

: [=effective sandbox flags/value=]
: [=effective sandboxing flags/value=]
:: The [=fencedframetype/default fenced frame effective sandboxing flags=].

: [=effective sandbox flags/visibility=]
: [=effective sandboxing flags/visibility=]
:: [=visibility/opaque=]

: [=fenced frame config/effective enabled permissions=]
Expand Down
Loading