Fix compilation waning "Missing #interrupt-cells"

Resolve : "Missing #interrupt-cells" warning duriing dts(device tree source) compilation hdata/test/p81-811.spira.dts:1434.37-1442.4: Warning (interrupt_provider): /interrupt-controller@3ffff80030000: Missing #interrupt-cells in interrupt provider An #interrupt-cells added to both reference dts for testing and source code to generate dtb from hdata. Signed-off-by: Abhishek Singh Tomar <[email protected]> Signed-off-by: Cédric Le Goater <[email protected]>
WMC2021 · Feb 4, 2022 · 81aa2af · 81aa2af
1 parent a9bc782
commit 81aa2af
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 0 deletions.
diff --git a/hdata/pcia.c b/hdata/pcia.c
@@ -78,6 +78,7 @@ static void add_xics_icp(const void *pcia, u32 tcount, const char *compat)
 	dt_add_property_cells(icp, "ibm,interrupt-server-ranges",
 			      irange[0], irange[1]);
 	dt_add_property(icp, "interrupt-controller", NULL, 0);
+	dt_add_property_cells(icp, "#interrupt-cells", 1);
 	dt_add_property(icp, "reg", reg, rsize);
 	dt_add_property_cells(icp, "#address-cells", 0);
 	dt_add_property_string(icp, "device_type",

diff --git a/hdata/test/p8-840-spira.dts b/hdata/test/p8-840-spira.dts
@@ -472,6 +472,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0x28 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <1>;
 		reg = <0x3ffff 0x80028000 0x0 0x1000 0x3ffff 0x80029000 0x0 0x1000 0x3ffff 0x8002a000 0x0 0x1000 0x3ffff 0x8002b000 0x0 0x1000 0x3ffff 0x8002c000 0x0 0x1000 0x3ffff 0x8002d000 0x0 0x1000 0x3ffff 0x8002e000 0x0 0x1000 0x3ffff 0x8002f000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -482,6 +483,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0x60 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <1>;
 		reg = <0x3ffff 0x80060000 0x0 0x1000 0x3ffff 0x80061000 0x0 0x1000 0x3ffff 0x80062000 0x0 0x1000 0x3ffff 0x80063000 0x0 0x1000 0x3ffff 0x80064000 0x0 0x1000 0x3ffff 0x80065000 0x0 0x1000 0x3ffff 0x80066000 0x0 0x1000 0x3ffff 0x80067000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -492,6 +494,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0x68 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <1>;
 		reg = <0x3ffff 0x80068000 0x0 0x1000 0x3ffff 0x80069000 0x0 0x1000 0x3ffff 0x8006a000 0x0 0x1000 0x3ffff 0x8006b000 0x0 0x1000 0x3ffff 0x8006c000 0x0 0x1000 0x3ffff 0x8006d000 0x0 0x1000 0x3ffff 0x8006e000 0x0 0x1000 0x3ffff 0x8006f000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -502,6 +505,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0xb0 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <1>;
 		reg = <0x3ffff 0x80130000 0x0 0x1000 0x3ffff 0x80131000 0x0 0x1000 0x3ffff 0x80132000 0x0 0x1000 0x3ffff 0x80133000 0x0 0x1000 0x3ffff 0x80134000 0x0 0x1000 0x3ffff 0x80135000 0x0 0x1000 0x3ffff 0x80136000 0x0 0x1000 0x3ffff 0x80137000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -512,6 +516,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0xe8 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <1>;
 		reg = <0x3ffff 0x80168000 0x0 0x1000 0x3ffff 0x80169000 0x0 0x1000 0x3ffff 0x8016a000 0x0 0x1000 0x3ffff 0x8016b000 0x0 0x1000 0x3ffff 0x8016c000 0x0 0x1000 0x3ffff 0x8016d000 0x0 0x1000 0x3ffff 0x8016e000 0x0 0x1000 0x3ffff 0x8016f000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -522,6 +527,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0xf0 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <1>;
 		reg = <0x3ffff 0x80170000 0x0 0x1000 0x3ffff 0x80171000 0x0 0x1000 0x3ffff 0x80172000 0x0 0x1000 0x3ffff 0x80173000 0x0 0x1000 0x3ffff 0x80174000 0x0 0x1000 0x3ffff 0x80175000 0x0 0x1000 0x3ffff 0x80176000 0x0 0x1000 0x3ffff 0x80177000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";

diff --git a/hdata/test/p81-811.spira.dts b/hdata/test/p81-811.spira.dts
@@ -1425,6 +1425,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0x20 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <0x01>;
 		reg = <0x3ffff 0x80020000 0x0 0x1000 0x3ffff 0x80021000 0x0 0x1000 0x3ffff 0x80022000 0x0 0x1000 0x3ffff 0x80023000 0x0 0x1000 0x3ffff 0x80024000 0x0 0x1000 0x3ffff 0x80025000 0x0 0x1000 0x3ffff 0x80026000 0x0 0x1000 0x3ffff 0x80027000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -1435,6 +1436,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0x30 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <0x01>;
 		reg = <0x3ffff 0x80030000 0x0 0x1000 0x3ffff 0x80031000 0x0 0x1000 0x3ffff 0x80032000 0x0 0x1000 0x3ffff 0x80033000 0x0 0x1000 0x3ffff 0x80034000 0x0 0x1000 0x3ffff 0x80035000 0x0 0x1000 0x3ffff 0x80036000 0x0 0x1000 0x3ffff 0x80037000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -1445,6 +1447,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0x60 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <0x01>;
 		reg = <0x3ffff 0x80060000 0x0 0x1000 0x3ffff 0x80061000 0x0 0x1000 0x3ffff 0x80062000 0x0 0x1000 0x3ffff 0x80063000 0x0 0x1000 0x3ffff 0x80064000 0x0 0x1000 0x3ffff 0x80065000 0x0 0x1000 0x3ffff 0x80066000 0x0 0x1000 0x3ffff 0x80067000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -1455,6 +1458,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0x68 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <0x01>;
 		reg = <0x3ffff 0x80068000 0x0 0x1000 0x3ffff 0x80069000 0x0 0x1000 0x3ffff 0x8006a000 0x0 0x1000 0x3ffff 0x8006b000 0x0 0x1000 0x3ffff 0x8006c000 0x0 0x1000 0x3ffff 0x8006d000 0x0 0x1000 0x3ffff 0x8006e000 0x0 0x1000 0x3ffff 0x8006f000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -1465,6 +1469,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0x70 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <0x01>;
 		reg = <0x3ffff 0x80070000 0x0 0x1000 0x3ffff 0x80071000 0x0 0x1000 0x3ffff 0x80072000 0x0 0x1000 0x3ffff 0x80073000 0x0 0x1000 0x3ffff 0x80074000 0x0 0x1000 0x3ffff 0x80075000 0x0 0x1000 0x3ffff 0x80076000 0x0 0x1000 0x3ffff 0x80077000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -1475,6 +1480,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0xa8 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <0x01>;
 		reg = <0x3ffff 0x80128000 0x0 0x1000 0x3ffff 0x80129000 0x0 0x1000 0x3ffff 0x8012a000 0x0 0x1000 0x3ffff 0x8012b000 0x0 0x1000 0x3ffff 0x8012c000 0x0 0x1000 0x3ffff 0x8012d000 0x0 0x1000 0x3ffff 0x8012e000 0x0 0x1000 0x3ffff 0x8012f000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -1485,6 +1491,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0xb0 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <0x01>;
 		reg = <0x3ffff 0x80130000 0x0 0x1000 0x3ffff 0x80131000 0x0 0x1000 0x3ffff 0x80132000 0x0 0x1000 0x3ffff 0x80133000 0x0 0x1000 0x3ffff 0x80134000 0x0 0x1000 0x3ffff 0x80135000 0x0 0x1000 0x3ffff 0x80136000 0x0 0x1000 0x3ffff 0x80137000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -1495,6 +1502,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0xe0 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <0x01>;
 		reg = <0x3ffff 0x80160000 0x0 0x1000 0x3ffff 0x80161000 0x0 0x1000 0x3ffff 0x80162000 0x0 0x1000 0x3ffff 0x80163000 0x0 0x1000 0x3ffff 0x80164000 0x0 0x1000 0x3ffff 0x80165000 0x0 0x1000 0x3ffff 0x80166000 0x0 0x1000 0x3ffff 0x80167000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -1505,6 +1513,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0xe8 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <0x01>;
 		reg = <0x3ffff 0x80168000 0x0 0x1000 0x3ffff 0x80169000 0x0 0x1000 0x3ffff 0x8016a000 0x0 0x1000 0x3ffff 0x8016b000 0x0 0x1000 0x3ffff 0x8016c000 0x0 0x1000 0x3ffff 0x8016d000 0x0 0x1000 0x3ffff 0x8016e000 0x0 0x1000 0x3ffff 0x8016f000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -1515,6 +1524,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0xf0 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <0x01>;
 		reg = <0x3ffff 0x80170000 0x0 0x1000 0x3ffff 0x80171000 0x0 0x1000 0x3ffff 0x80172000 0x0 0x1000 0x3ffff 0x80173000 0x0 0x1000 0x3ffff 0x80174000 0x0 0x1000 0x3ffff 0x80175000 0x0 0x1000 0x3ffff 0x80176000 0x0 0x1000 0x3ffff 0x80177000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -1525,6 +1535,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0x828 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <0x01>;
 		reg = <0x3ffff 0x80828000 0x0 0x1000 0x3ffff 0x80829000 0x0 0x1000 0x3ffff 0x8082a000 0x0 0x1000 0x3ffff 0x8082b000 0x0 0x1000 0x3ffff 0x8082c000 0x0 0x1000 0x3ffff 0x8082d000 0x0 0x1000 0x3ffff 0x8082e000 0x0 0x1000 0x3ffff 0x8082f000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -1535,6 +1546,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0x830 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <0x01>;
 		reg = <0x3ffff 0x80830000 0x0 0x1000 0x3ffff 0x80831000 0x0 0x1000 0x3ffff 0x80832000 0x0 0x1000 0x3ffff 0x80833000 0x0 0x1000 0x3ffff 0x80834000 0x0 0x1000 0x3ffff 0x80835000 0x0 0x1000 0x3ffff 0x80836000 0x0 0x1000 0x3ffff 0x80837000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -1545,6 +1557,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0x860 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <0x01>;
 		reg = <0x3ffff 0x80860000 0x0 0x1000 0x3ffff 0x80861000 0x0 0x1000 0x3ffff 0x80862000 0x0 0x1000 0x3ffff 0x80863000 0x0 0x1000 0x3ffff 0x80864000 0x0 0x1000 0x3ffff 0x80865000 0x0 0x1000 0x3ffff 0x80866000 0x0 0x1000 0x3ffff 0x80867000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -1555,6 +1568,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0x868 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <0x01>;
 		reg = <0x3ffff 0x80868000 0x0 0x1000 0x3ffff 0x80869000 0x0 0x1000 0x3ffff 0x8086a000 0x0 0x1000 0x3ffff 0x8086b000 0x0 0x1000 0x3ffff 0x8086c000 0x0 0x1000 0x3ffff 0x8086d000 0x0 0x1000 0x3ffff 0x8086e000 0x0 0x1000 0x3ffff 0x8086f000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -1565,6 +1579,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0x870 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <0x01>;
 		reg = <0x3ffff 0x80870000 0x0 0x1000 0x3ffff 0x80871000 0x0 0x1000 0x3ffff 0x80872000 0x0 0x1000 0x3ffff 0x80873000 0x0 0x1000 0x3ffff 0x80874000 0x0 0x1000 0x3ffff 0x80875000 0x0 0x1000 0x3ffff 0x80876000 0x0 0x1000 0x3ffff 0x80877000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -1575,6 +1590,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0x8a0 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <0x01>;
 		reg = <0x3ffff 0x80920000 0x0 0x1000 0x3ffff 0x80921000 0x0 0x1000 0x3ffff 0x80922000 0x0 0x1000 0x3ffff 0x80923000 0x0 0x1000 0x3ffff 0x80924000 0x0 0x1000 0x3ffff 0x80925000 0x0 0x1000 0x3ffff 0x80926000 0x0 0x1000 0x3ffff 0x80927000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -1585,6 +1601,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0x8a8 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <0x01>;
 		reg = <0x3ffff 0x80928000 0x0 0x1000 0x3ffff 0x80929000 0x0 0x1000 0x3ffff 0x8092a000 0x0 0x1000 0x3ffff 0x8092b000 0x0 0x1000 0x3ffff 0x8092c000 0x0 0x1000 0x3ffff 0x8092d000 0x0 0x1000 0x3ffff 0x8092e000 0x0 0x1000 0x3ffff 0x8092f000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -1595,6 +1612,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0x8b0 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <0x01>;
 		reg = <0x3ffff 0x80930000 0x0 0x1000 0x3ffff 0x80931000 0x0 0x1000 0x3ffff 0x80932000 0x0 0x1000 0x3ffff 0x80933000 0x0 0x1000 0x3ffff 0x80934000 0x0 0x1000 0x3ffff 0x80935000 0x0 0x1000 0x3ffff 0x80936000 0x0 0x1000 0x3ffff 0x80937000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -1605,6 +1623,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0x8e8 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <0x01>;
 		reg = <0x3ffff 0x80968000 0x0 0x1000 0x3ffff 0x80969000 0x0 0x1000 0x3ffff 0x8096a000 0x0 0x1000 0x3ffff 0x8096b000 0x0 0x1000 0x3ffff 0x8096c000 0x0 0x1000 0x3ffff 0x8096d000 0x0 0x1000 0x3ffff 0x8096e000 0x0 0x1000 0x3ffff 0x8096f000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";
@@ -1615,6 +1634,7 @@
 		compatible = "ibm,ppc-xicp", "IBM,power8-icp";
 		ibm,interrupt-server-ranges = <0x8f0 0x8>;
 		interrupt-controller;
+		#interrupt-cells = <0x01>;
 		reg = <0x3ffff 0x80970000 0x0 0x1000 0x3ffff 0x80971000 0x0 0x1000 0x3ffff 0x80972000 0x0 0x1000 0x3ffff 0x80973000 0x0 0x1000 0x3ffff 0x80974000 0x0 0x1000 0x3ffff 0x80975000 0x0 0x1000 0x3ffff 0x80976000 0x0 0x1000 0x3ffff 0x80977000 0x0 0x1000>;
 		#address-cells = <0x0>;
 		device_type = "PowerPC-External-Interrupt-Presentation";