Well phenotype probability comparisons #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
MikeLippincott
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Great clean PR! Consider making edits in the documentation sections of the functions specifically adding summaries to the docstrings stating what the purpose of the function is. Also, consider adding type hints to the functions.
I think if you choose to apply these edits, they are pretty straight forward so I am going to approve this PR, but please let me know if you want me to take another look?
...ze_data/nbconverted/log_reg_class_balanced_areashape_analyze_well_predicted_probabilities.py
Show resolved
Hide resolved
...ze_data/nbconverted/log_reg_class_balanced_areashape_analyze_well_predicted_probabilities.py
Outdated
Show resolved
Hide resolved
...ze_data/nbconverted/log_reg_class_balanced_areashape_analyze_well_predicted_probabilities.py
Show resolved
Hide resolved
...ze_data/nbconverted/log_reg_class_balanced_areashape_analyze_well_predicted_probabilities.py
Show resolved
Hide resolved
|
Thanks Mike, merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr, the predicted probabilities of phenotypes are compared between treated wells and the negative control(s). This is accomplished by comparing the predicted probabilities of cells in each treatment well with cells in the control wells. Stratified sampling of cells from control wells ensure a proportionate representation of cell populations during these comparisons. Wells with a cell count bellow 50 are disregarded. To create the comparisons I performed a KS test between the respective control and treatment probability distributions. Another pr will be created to update the README and possibly other intermediary scripts. Please let me know if you have any questions or suggestions.