-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE-580 Feature/annotation group #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pantelisss
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Check my comment and is up to you
JohnFrontzos
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tho the majority of changes are out of this PR scope (talking about the helper functions)
PavlosTze
temporarily deployed
to
development
February 15, 2024 12:55 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Integrate new
annotation_summary
property.How?
annotationSummary
in the API Models andRewardsAnnotationGroup
which is the new structure we will use.MessageCardView
in order to implement the new annotationsRewardProblemsAdapter
to use the newRewardsAnnotatonGroup
as input dataTesting
Either run
localMockDebug
flavor or the dev build (which communicates with the dev API) and ensure everything is OK rewards-related.Others:
Replace the following:
device.relation == DeviceRelation.OWNED
device.relation == DeviceRelation.FOLLOWED
device.relation == DeviceRelation.UNFOLLOWED
With the respective extension functions:
device.isOwned()
device.isFollowed()
device.isUnfollowed()