Share photos implementation (including test code) #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavlosTze
had a problem deploying
to
production
GitHub Actions
Failure
Coverage Report (Type: Instructions)
|
PavlosTze
force-pushed
the
feature/fe-1347-share-photos-action
branch
from
2c10588 to
f61cba9
Compare
PavlosTze
had a problem deploying
to
production
GitHub Actions
Failure
PavlosTze
force-pushed
the
feature/fe-1347-share-photos-action
branch
from
f61cba9 to
29ac7ce
Compare
PavlosTze
had a problem deploying
to
production
GitHub Actions
Failure
PavlosTze
had a problem deploying
to
production
GitHub Actions
Failure
pantelisss
approved these changes
Dec 13, 2024
PavlosTze
merged commit e82865d
into
feature/fe-1344-photo-capturing-and-gallery-screens
5 of 6 checks passed
PavlosTze
added a commit
that referenced
this pull request
Dec 13, 2024
* [WIP] Implement the first states of the photo gallery. Without camera permission and with no photos. * Fix permissions for camera * Upload button functionality * Save the captured photo in files, save their paths and update the UI based on the number of current photos * Create the thumbnails. Moved normalizedName function to UIDevice. Pass device object to photo verification screens. * Support landscape photos. Show selected photo in full size. * Delete the local file when the user presses the delete button * Fix detekt * Fix unit tests * Open camera permisssions and camera only if gallery is empy. Auto-select the latest photo taken at all cases. * On gallery onCreate click the "+" button automatically. Fix background of good and bad examples in intro. * Share photos implementation (including test code) (#438) * Share photos implementation (including test code) * Use a different file provider for each flavor (distinct by applicationId)
PavlosTze
added a commit
that referenced
this pull request
Dec 17, 2024
* [WIP] Implement the first states of the photo gallery. Without camera permission and with no photos. * Fix permissions for camera * Upload button functionality * Save the captured photo in files, save their paths and update the UI based on the number of current photos * Create the thumbnails. Moved normalizedName function to UIDevice. Pass device object to photo verification screens. * Support landscape photos. Show selected photo in full size. * Delete the local file when the user presses the delete button * Fix detekt * Fix unit tests * Open camera permisssions and camera only if gallery is empy. Auto-select the latest photo taken at all cases. * On gallery onCreate click the "+" button automatically. Fix background of good and bad examples in intro. * Share photos implementation (including test code) (#438) * Share photos implementation (including test code) * Use a different file provider for each flavor (distinct by applicationId)
PavlosTze
added a commit
that referenced
this pull request
Jan 7, 2025
* [WIP] Implement the first states of the photo gallery. Without camera permission and with no photos. * Fix permissions for camera * Upload button functionality * Save the captured photo in files, save their paths and update the UI based on the number of current photos * Create the thumbnails. Moved normalizedName function to UIDevice. Pass device object to photo verification screens. * Support landscape photos. Show selected photo in full size. * Delete the local file when the user presses the delete button * Fix detekt * Fix unit tests * Open camera permisssions and camera only if gallery is empy. Auto-select the latest photo taken at all cases. * On gallery onCreate click the "+" button automatically. Fix background of good and bad examples in intro. * Share photos implementation (including test code) (#438) * Share photos implementation (including test code) * Use a different file provider for each flavor (distinct by applicationId)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
After capturing a photo and pressing the upload button, the user should have the option to share their photos by selecting the corresponding button.
How?
openShareImageswhich is responsible for sharing the images, given anArrayList<Uri>.Testing
Follow the flow in local mock and in the gallery I have transformed the Upload button to be used as "Share".